fix: Added missing display profiles#341
Merged
Merged
Conversation
Contributor
Reviewer's GuideThis PR reorganizes import statements, extends the DisplayProfile enum with missing HDR10+ and Dolby Vision HLG profiles, and refactors the fromVideoStream method to use a switch expression covering all VideoRangeType cases. Updated Class Diagram for DisplayProfile EnumclassDiagram
class DisplayProfile {
<<Enumeration>>
sdr
hdr
hdr10
hdr10Plus
dolbyVision
dolbyVisionHdr10
dolbyVisionHlg
hlg
+value: String
+getResolution(): Resolution
+getProfile(): DisplayProfile
+fromVideoStream(stream: VideoStreamModel): DisplayProfile
}
note for DisplayProfile "New enum members: hdr10Plus, dolbyVisionHlg.\nThe fromVideoStream() method logic has been updated to use a switch expression, covering more VideoRangeType cases."
Flow Diagram for Updated fromVideoStream Method Logicflowchart TD
A[Input: stream.videoRangeType] --> B{Switch on videoRangeType};
B -- dto.VideoRangeType.doviwithsdr --> C[DisplayProfile.dolbyVisionHlg];
B -- dto.VideoRangeType.doviwithhdr10 --> D[DisplayProfile.dolbyVisionHdr10];
B -- dto.VideoRangeType.dovi --> E[DisplayProfile.dolbyVision];
B -- dto.VideoRangeType.hlg --> F[DisplayProfile.hlg];
B -- dto.VideoRangeType.hdr10 --> G[DisplayProfile.hdr10];
B -- dto.VideoRangeType.doviwithhlg --> H[DisplayProfile.dolbyVisionHlg];
B -- dto.VideoRangeType.hdr10plus --> I[DisplayProfile.hdr10Plus];
B -- _ (default) --> J[DisplayProfile.sdr];
C --> K[Output: DisplayProfile];
D --> K;
E --> K;
F --> K;
G --> K;
H --> K;
I --> K;
J --> K;
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @PartyDonut - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| default: | ||
| return DisplayProfile.sdr; | ||
| } | ||
| return switch (stream.videoRangeType) { |
Contributor
There was a problem hiding this comment.
issue: Null videoRangeType now maps to SDR instead of HLG
To preserve the old HLG mapping for null, add a case null => DisplayProfile.hlg before the other cases or adjust the default branch.
Julien9969
pushed a commit
to Julien9969/Fladder
that referenced
this pull request
May 20, 2025
Co-authored-by: PartyDonut <PartyDonut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add missing video profile types
Resolves #313