fix: Shuffle play videos#345
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey @PartyDonut - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| PageTransition( | ||
| child: PhotoViewerScreen( | ||
| items: allItems, | ||
| items: shuffle ? allItems.shuffled() : allItems, |
Contributor
There was a problem hiding this comment.
issue (bug_risk): indexOfSelected not recalculated for shuffled items
Compute indexOfSelected on shuffled items when shuffle is true to avoid opening the wrong photo.
Contributor
Reviewer's GuideThis PR enhances the library playback flow by restricting to playable video items, propagating the shuffle flag to playback APIs, and applying shuffle to the photo viewer list when shuffle mode is enabled. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Julien9969
pushed a commit
to Julien9969/Fladder
that referenced
this pull request
May 20, 2025
Co-authored-by: PartyDonut <PartyDonut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Apply shuffle to photo/video libraries
Fix non-video files being added to playback list when playing videos
Issue Being Fixed
Resolves #322