Skip to content

chore: Added Applications folder in Mac installer#369

Merged
PartyDonut merged 6 commits intoDonutWare:developfrom
schembriaiden:macos-drag-and-drop
Jun 7, 2025
Merged

chore: Added Applications folder in Mac installer#369
PartyDonut merged 6 commits intoDonutWare:developfrom
schembriaiden:macos-drag-and-drop

Conversation

@schembriaiden
Copy link
Copy Markdown
Contributor

@schembriaiden schembriaiden commented Jun 5, 2025

Pull Request Description

changed mac installer to utilise create-dmg with a background

Issue Being Fixed

This streamlines the installation process on Mac

Screenshots / Recordings

Screenshot 2025-06-07 at 14 06 12

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

@schembriaiden schembriaiden changed the title chore: Added Applications folder for Mac .dmg chore: Added Applications folder in Mac installer Jun 5, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jun 5, 2025

Reviewer's Guide

Refactors the macOS CI workflow to produce a UDZO DMG containing a symlink to the Applications folder, enabling drag-and-drop installation.

Sequence Diagram: CI Steps for Enhanced macOS DMG Creation

sequenceDiagram
    actor CIJob as GitHub Actions Runner
    participant FS as File System
    participant HDIUTIL as hdiutil

    CIJob->>FS: mkdir -p dmg_temp
    CIJob->>FS: cp -R build/macos/Build/Products/Release-production/Fladder.app dmg_temp/
    CIJob->>FS: ln -s /Applications dmg_temp/Applications
    CIJob->>HDIUTIL: hdiutil create -volname "Fladder" -srcfolder dmg_temp -ov -format UDZO macOS.dmg
    HDIUTIL-->>CIJob: macOS.dmg created
    CIJob->>FS: rm -rf dmg_temp
Loading

File-Level Changes

Change Details Files
Enhanced DMG creation step to support drag-and-drop installation
  • Renamed step to 'Create DMG with drag and drop to Applications'
  • Introduced temporary staging directory (dmg_temp)
  • Copied Fladder.app into staging directory
  • Added symbolic link to /Applications in staging directory
  • Updated hdiutil invocation to use staging directory and set volume name
  • Cleaned up temporary staging directory after DMG creation
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vikingnope - I've reviewed your changes - here's some feedback:

  • Use mktemp -d to generate a unique temporary directory instead of a fixed dmg_temp to avoid collisions.
  • Add set -e and a trap to ensure the temporary directory is always cleaned up even if hdiutil or other commands fail.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@PartyDonut
Copy link
Copy Markdown
Collaborator

Thanks for implementing this looks like a good addition. We can merge it as is, however I added a background we could use for the dmg "assets\macos-dmg\Fladder-DMG-Background.jpg".

Let me know if you are willing to implement this into the build steps using something like create-dmg.

PartyDonut
PartyDonut previously approved these changes Jun 7, 2025
@schembriaiden
Copy link
Copy Markdown
Contributor Author

schembriaiden commented Jun 7, 2025

Thanks for implementing this looks like a good addition. We can merge it as is, however I added a background we could use for the dmg "assets\macos-dmg\Fladder-DMG-Background.jpg".

Let me know if you are willing to implement this into the build steps using something like create-dmg.

Oh that's perfect, I was going to do this but I didn't have a background, I will try implementing it again before you merge this.

@schembriaiden
Copy link
Copy Markdown
Contributor Author

schembriaiden commented Jun 7, 2025

Could we maybe change the background slightly by adding some kind of different colour at the text parts of the folder and the app so that they are visible, because currently they are not that visible and there is no way to remove the text nor change their colour:

Screenshot 2025-06-07 at 12 52 17 Screenshot 2025-06-07 at 12 53 52

These are some examples:

Screenshot 2025-06-07 at 12 43 56 Screenshot 2025-06-07 at 12 44 32

@PartyDonut
Copy link
Copy Markdown
Collaborator

I've changed the background to be lighter, also decreased the drag-target size to not clip into the "applications" text. Let me know if the new version works.

Changes are pushed to develop

@schembriaiden
Copy link
Copy Markdown
Contributor Author

Okay it should be finished now, let me know what you think 😄

Copy link
Copy Markdown
Collaborator

@PartyDonut PartyDonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for implementing this 🥳

@PartyDonut PartyDonut merged commit 2f7d7bc into DonutWare:develop Jun 7, 2025
1 check passed
@schembriaiden schembriaiden deleted the macos-drag-and-drop branch June 7, 2025 12:38
Julien9969 pushed a commit to Julien9969/Fladder that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants