chore: Added Applications folder in Mac installer#369
chore: Added Applications folder in Mac installer#369PartyDonut merged 6 commits intoDonutWare:developfrom
Conversation
Reviewer's GuideRefactors the macOS CI workflow to produce a UDZO DMG containing a symlink to the Applications folder, enabling drag-and-drop installation. Sequence Diagram: CI Steps for Enhanced macOS DMG CreationsequenceDiagram
actor CIJob as GitHub Actions Runner
participant FS as File System
participant HDIUTIL as hdiutil
CIJob->>FS: mkdir -p dmg_temp
CIJob->>FS: cp -R build/macos/Build/Products/Release-production/Fladder.app dmg_temp/
CIJob->>FS: ln -s /Applications dmg_temp/Applications
CIJob->>HDIUTIL: hdiutil create -volname "Fladder" -srcfolder dmg_temp -ov -format UDZO macOS.dmg
HDIUTIL-->>CIJob: macOS.dmg created
CIJob->>FS: rm -rf dmg_temp
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @vikingnope - I've reviewed your changes - here's some feedback:
- Use mktemp -d to generate a unique temporary directory instead of a fixed
dmg_tempto avoid collisions. - Add
set -eand atrapto ensure the temporary directory is always cleaned up even ifhdiutilor other commands fail.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Thanks for implementing this looks like a good addition. We can merge it as is, however I added a background we could use for the dmg "assets\macos-dmg\Fladder-DMG-Background.jpg". Let me know if you are willing to implement this into the build steps using something like create-dmg. |
Oh that's perfect, I was going to do this but I didn't have a background, I will try implementing it again before you merge this. |
|
I've changed the background to be lighter, also decreased the drag-target size to not clip into the "applications" text. Let me know if the new version works. Changes are pushed to develop |
|
Okay it should be finished now, let me know what you think 😄 |
PartyDonut
left a comment
There was a problem hiding this comment.
lgtm, thanks for implementing this 🥳




Pull Request Description
changed mac installer to utilise
create-dmgwith a backgroundIssue Being Fixed
This streamlines the installation process on Mac
Screenshots / Recordings
Checklist