bug: Fix undefined Inno AppVersion

[schembriaiden]

Pull Request Description

It seems to be that there is an issue where the FLADDER_VERSION environment variable is not defined so the inno installer defaults to latest everytime. This causes several issues such as:

• Inno installer just saying latest
• App Version in Settings/Control Panel saying latest
• Issues with creating new Winget manifests

This PR should fix this issue by overwriting the inno installer file with the latest version.

Issue Being Fixed

Inno installer version not being defined correctly.

Screenshots / Recordings

Before:

After:

Checklist

• If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
• Check that any changes are related to the issue at hand.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure the Inno installer always uses the correct application version by defining a default FLADDER_VERSION in the setup script and updating the CI workflow to pass the actual version as a compiler define.

Class diagram for updated windows_setup.iss version handling

classDiagram
    class Setup {
        +AppId
        +AppName
        +AppVersion
        +AppPublisher
        +AppPublisherURL
        +AppSupportURL
    }
    class FLADDER_VERSION {
        <<define>>
        value: string
    }
    FLADDER_VERSION <|-- Setup: uses

Loading

File-Level Changes

Change	Details	Files
Add default FLADDER_VERSION in Inno Setup script	Insert #ifndef guard to define FLADDER_VERSION as "latest" when undefined Switch AppVersion directive to reference the FLADDER_VERSION macro	windows/windows_setup.iss
Modify GitHub Actions workflow to pass FLADDER_VERSION via compiler flag	Remove standalone FLADDER_VERSION env variable setup Add /DFLADDER_VERSION="${{ needs.fetch-info.outputs.version_name }}" to Inno-Setup-Action options	.github/workflows/build.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[PartyDonut]

Looks good to me thanks for fixing this.