Skip to content

fix: Winget workflow max-versions#554

Merged
PartyDonut merged 1 commit intoDonutWare:developfrom
schembriaiden:fix-max-versions
Nov 1, 2025
Merged

fix: Winget workflow max-versions#554
PartyDonut merged 1 commit intoDonutWare:developfrom
schembriaiden:fix-max-versions

Conversation

@schembriaiden
Copy link
Copy Markdown
Contributor

@schembriaiden schembriaiden commented Nov 1, 2025

Pull Request Description

Fixes issue since max versions was not set, it is now set to 0 to keep all versions

I have already created a PR for the new release on the winget-pkgs repo, but this resolves the issue for next time.

Issue Being Fixed

Workflow failure due to max-versions not be set for winget-submit

Screenshot:

Screenshot 2025-11-01 at 15 15 41

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

@schembriaiden schembriaiden changed the title bug: Fix issue in winget workflow of max versions bug: Fix issue with winget workflow max-versions Nov 1, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Nov 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR addresses a workflow failure in the winget submission by properly setting the max_versions parameter and cleans up minor YAML formatting inconsistencies.

File-Level Changes

Change Details Files
Standardized YAML formatting by removing extraneous trailing spaces.
  • Trimmed trailing spaces on Build Date, Build Number, and Commit lines
.github/workflows/build.yml
Fixed winget-submit configuration by initializing max_versions.
  • Replaced empty max_versions value with "0" to retain all versions
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@PartyDonut PartyDonut added the bug Something isn't working label Nov 1, 2025
@PartyDonut PartyDonut merged commit c3f04b7 into DonutWare:develop Nov 1, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this to Done in Fladder Nov 1, 2025
@schembriaiden schembriaiden deleted the fix-max-versions branch November 1, 2025 18:21
@schembriaiden schembriaiden changed the title bug: Fix issue with winget workflow max-versions fix: Winget workflow max-versions Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants