fix: Parsing non-ascii domains#643
Conversation
- added puny coder dependency - non-ascii domains can now be resolved
PartyDonut
left a comment
PartyDonut
left a comment
There was a problem hiding this comment.
Thanks for fixing this 😄.
Left a few tinny requests.
Would also request you to have a look at the settings.json inside of the .vscode folder for formatting options.
Currently it looks like you're formatting the files on a different line length. Please reformat it using the 120 line.length.
- fixed wrapping settings to follow code guidelines(kept .zed settings to for zed to follow wrapping rules) - moved puny coder to network section - moved url function to normalizer - added path for reverse proxy custom path support
|
I decided to also check issue #641 it was a really small fix so i decided to just add it to this pull request if that's fine. |
- Change matching boolean for language as language code matched will not work with multi-character/dialect
PartyDonut
left a comment
PartyDonut
left a comment
There was a problem hiding this comment.
The fix for the url looks fine to me thanks for implementing the feedback. Lets remove the locale commit though. Will merge it after that.
Even if the locale commit fix is very small. The release notes are generated based on the merged pull-requests so would be better to separate it. Just to keep the release notes clean.
I also include small commits together which is a bad habit of mine so I understand why 😄
This reverts commit a0182ef.
|
Thanks for fixing this! |
2 participants
Pull Request Description
just changed api_provider.dart to use punycoder to encode non-ascii characters in domain names
Issue Being Fixed
Resolves #640
Screenshots / Recordings
no visual change
Checklist