-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add iOS launchAppWithArguments #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -211,6 +211,19 @@ public Dictionary<string, object> Settings | |||||
| public void InstallApp(string appPath, int? timeoutMs = null) => | ||||||
| IOSCommandExecutionHelper.InstallApp(this, appPath, timeoutMs); | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// Launch an app on the iOS device using mobile: launchApp script. | ||||||
| /// For documentation, see <see href="https://appium.github.io/appium-xcuitest-driver/latest/reference/execute-methods/#mobile-launchapp">mobile: launchApp</see>. | ||||||
| /// </summary> | ||||||
| /// <param name="bundleId">The bundle identifier of the application.</param> | ||||||
| /// <param name="processArguments">Optional command line arguments for the app.</param> | ||||||
| /// <param name="environmentVariables">Optional environment variables for the app.</param> | ||||||
| public void LaunchAppWithArguments( | ||||||
| string bundleId, | ||||||
| IReadOnlyCollection<string> processArguments = null, | ||||||
|
||||||
| IReadOnlyCollection<string> processArguments = null, | |
| IReadOnlyList<string> processArguments = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command-line arguments are inherently ordered. Using IReadOnlyCollection for processArguments allows unordered implementations (e.g., HashSet), which could scramble argument order when serialized. Consider changing this to IReadOnlyList (or IEnumerable but documented as ordered) to better represent the required semantics.