Create markdown-links-verifier.yml#3318
Closed
Youssef1313 wants to merge 2 commits intoDotNetAnalyzers:masterfrom
Closed
Create markdown-links-verifier.yml#3318Youssef1313 wants to merge 2 commits intoDotNetAnalyzers:masterfrom
Youssef1313 wants to merge 2 commits intoDotNetAnalyzers:masterfrom
Conversation
Contributor
Author
|
The image is most probably existed only when the docs where at http://www.stylecop.com/docs/SA1305.html. |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #3318 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 1021 1021
Lines 110375 110375
Branches 3813 3813
=======================================
Hits 103237 103237
Misses 6179 6179
Partials 959 959 |
Member
|
The image is not still relevant. |
Contributor
Author
|
@sharwell I deleted the image and updated the documentation. Let me know if you don't want to use the GH Action to delete it. |
sharwell
reviewed
Mar 15, 2021
| @@ -0,0 +1,14 @@ | |||
| name: Markdown links verifier | |||
Member
There was a problem hiding this comment.
📝 For now I'd prefer to not add the action. Can you resubmit just the fixed documentation file as a separate PR? This one can stay closed so future reviewers are aware of its existence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results:
The GitHub Action wasn't run in the PR, only in my fork. This is probably due GitHub Actions being disabled in the repository?
If you don't want to enable this GH Action, let's fix the broken image only.