Added a test for Common JS Closure usage#3
Merged
DuncanUszkay1 merged 1 commit intomasterfrom Jun 19, 2020
Merged
Conversation
Owner
|
More tests sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to AssemblyScript#1308
relates to AssemblyScript#1240 (comment)
Adding my test I wrote a while back where I research common use cases we should probably try to support for it to feel natural for JS devs coming to AS.
Tests fail on the current master, but it also fails for the normal closure test, but it used to pass on the old closures so I don't think it should be a blocker 😄 👍
Screenshot