Add initial mailhog-command #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
mrrobot47
changed the title
Signed-off-by: Riddhesh Sanghvi <[email protected]>
rahulsprajapati
previously approved these changes
Aug 21, 2018
src/Mailhog_Command.php
Outdated
| /** | ||
| * @var array $db Object containing essential site related information. | ||
| */ | ||
| private $db; |
Contributor
There was a problem hiding this comment.
Please change this variable name if it's used for site info and not the database. Maybe $site_data would be more suitable or $site.
$db is look like it's for getting db instance.
Signed-off-by: Riddhesh Sanghvi <[email protected]>
mbtamuli
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: EasyEngine/easyengine#1163
Depends on: EasyEngine/site-type-wp#7
Depends on: EasyEngine/easyengine#1143
Closes EasyEngine/site-type-wp#7
Add support for:
Signed-off-by: Riddhesh Sanghvi [email protected]