Deprecate constant lookups via .const_missing#10
Merged
lanej merged 17 commits intoEasyPost:masterfrom Aug 16, 2021
Merged
Conversation
* Store the feature tree as nested hashes * Add simplified query methods * Continue to support constant lookups
398e885 to
5a5e115
Compare
kgraves
reviewed
Aug 11, 2021
kgraves
reviewed
Aug 11, 2021
06cbf65 to
21deac3
Compare
Roguelazer
reviewed
Aug 14, 2021
| @@ -0,0 +1,47 @@ | |||
| class Feature::ConstantLookup | |||
| Error = Class.new(NameError) do | |||
Contributor
There was a problem hiding this comment.
why not just define this as, you know,
class Error < NameError do
...
end
Anonymous classes often feel like a code smell to me
Member
Author
There was a problem hiding this comment.
not an anonymous class, just a different way to declare a subclass.
Comment on lines
+15
to
+16
| Error = Class.new(StandardError) | ||
| Unknown = Class.new(Error) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant lookups are terrible. They cause cryptic errors and are hard to test without message expectations.