fix: handle abbreviations and numbers in feature name#11
Merged
lanej merged 5 commits intoEasyPost:masterfrom Aug 19, 2021
Merged
fix: handle abbreviations and numbers in feature name#11lanej merged 5 commits intoEasyPost:masterfrom
lanej merged 5 commits intoEasyPost:masterfrom
Conversation
kgraves
reviewed
Aug 16, 2021
kgraves
reviewed
Aug 19, 2021
Comment on lines
+29
to
+32
| key = sym.to_s | ||
| key.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2'.freeze) | ||
| key.gsub!(/([a-z\d])([A-Z])/, '\1_\2'.freeze) | ||
| key.downcase! |
There was a problem hiding this comment.
I'm still seeing that we're having some issues with translation of potential keys, but let me know if you don't see it as an issue right now, or something we'll fix later.
[2] pry(main)> def tr(str)
[2] pry(main)* str.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2'.freeze)
[2] pry(main)* str.gsub!(/([a-z\d])([A-Z])/, '\1_\2'.freeze)
[2] pry(main)* str.downcase!
[2] pry(main)* return str
[2] pry(main)* end
=> :tr
[3] pry(main)>
[4] pry(main)> tr("CN22")
=> "cn22"
[5] pry(main)> tr("Allow2DayAir")
=> "allow2_day_air"
[6] pry(main)> tr("Allow2ndDaySomething")
=> "allow2nd_day_something"
Member
Author
There was a problem hiding this comment.
As this a transitionary release and there is a workaround for it, I'm inclined to improve it within reason and then move on to a major release that removes support for module-based access entirely.
kgraves
approved these changes
Aug 19, 2021
Comment on lines
+29
to
+32
| key = sym.to_s | ||
| key.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2'.freeze) | ||
| key.gsub!(/([a-z\d])([A-Z])/, '\1_\2'.freeze) | ||
| key.downcase! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.