refactor: remove Feature::Base, just use Feature::Permissions

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        rubyversion: ['2.4', '2.5', '2.6', '2.7', '3.0']
+        rubyversion: ['2.7', '3.0', '3.1']
     steps:
       - uses: actions/checkout@v2
       - name: set up ruby

lib/toggles.rb

@@ -34,9 +34,7 @@ def init
       path = Pathname.new(abspath).relative_path_from(top_level_p).to_s
       features = path.split('/')[0..-2].inject(Feature.features) { |a, e| a[e.to_sym] ||= {} }
       feature_key = File.basename(path, File.extname(path)).to_sym
-      features[feature_key] = Class.new(Feature::Base) do |c|
-        c.const_set(:PERMISSIONS, Feature::Permissions.new(abspath))
-      end
+      features[feature_key] = Feature::Permissions.from_yaml(abspath)
     end
 
     stbuf = File.stat(top_level)

lib/toggles/feature.rb

@@ -31,7 +31,6 @@ def self.disabled?(*sym, **criteria)
 end
 
 require 'toggles/constant_lookup'
-require "toggles/feature/base"
 require "toggles/feature/attribute"
 require "toggles/feature/permissions"
 require "toggles/feature/subject"

lib/toggles/feature/permissions.rb

@@ -1,23 +1,26 @@
 require 'ostruct'
 require 'forwardable'
+require 'yaml'
 
-class Feature::Permissions
+Feature::Permissions = Struct.new(:rules) do
   extend Forwardable
 
-  attr_reader :rules
-
   def_delegators :rules, :all?, :keys
 
-  def initialize(path)
-    @rules = YAML.load(File.read(path))
+  def self.from_yaml(path)
+    new(
+      YAML.safe_load(File.read(path), permitted_classes: [Symbol])
+    )
   end
 
   def subjects
     @subjects ||= keys.map(&:to_sym)
   end
 
   def valid_for?(entities)
-    raise Feature::Subject::Invalid, Feature::Subject.difference(subjects, entities.keys) unless subjects == entities.keys
+    unless subjects == entities.keys
+      raise Feature::Subject::Invalid, Feature::Subject.difference(subjects, entities.keys)
+    end
 
     rules.all? do |name, rule|
       entity = entities[name.to_sym]
@@ -34,4 +37,12 @@ def valid_for?(entities)
       end
     end
   end
+
+  def enabled_for?(subjects = {})
+    valid_for?(subjects)
+  end
+
+  def disabled_for?(subjects = {})
+    !valid_for?(subjects)
+  end
 end

spec/toggles/feature/permissions_spec.rb

@@ -1,7 +1,7 @@
 describe Feature::Permissions do
   let(:path) { "features/multiple_subjects.yml" }
 
-  subject { Feature::Permissions.new(path) }
+  subject { Feature::Permissions.from_yaml(path) }
 
   its(:rules)    { is_expected.to eq({"user"=>{"id"=>1, "logged_in?"=>true},
                                       "widget"=>{"id"=>2}}) }

spec/toggles/feature_spec.rb

@@ -0,0 +1,37 @@
+describe 'features' do
+  let(:user)   { double(id: 1, logged_in?: true) }
+  let(:widget) { double(id: 2) }
+
+  context 'multiple subjects' do
+    specify { expect(Feature).to be_enabled(:multiple_subjects, user: user, widget: widget) }
+    specify { expect(Feature::MultipleSubjects).to be_enabled_for(user: user, widget: widget) }
+    specify { expect(Feature).not_to be_disabled(:multiple_subjects, user: user, widget: widget) }
+    specify { expect(Feature::MultipleSubjects).not_to be_disabled_for(user: user, widget: widget) }
+  end
+
+  context 'abbreviation with numbers' do
+    subject { Feature::AbbreviationsCN22.new(user: user) }
+
+    specify { expect(Feature).to be_enabled(:abbreviations_cn22, user: user) }
+    specify { expect(Feature::AbbreviationsCN22).to be_enabled_for(user: user) }
+    specify { expect(Feature).not_to be_disabled(:abbreviations_cn22, user: user) }
+    specify { expect(Feature::AbbreviationsCN22).not_to be_disabled_for(user: user) }
+  end
+
+  context 'irregular capitalization' do
+    specify { expect(Feature).to be_enabled(:s3_file, user: user) }
+    specify { expect(Feature::S3File).to be_enabled_for(user: user) }
+    specify { expect(Feature).not_to be_disabled(:s3_file, user: user) }
+    specify { expect(Feature).to be_disabled(:s3_file, user: widget) }
+    specify { expect(Feature::S3File).not_to be_disabled_for(user: user) }
+    specify { expect(Feature::S3File).to be_disabled_for(user: widget) }
+  end
+
+  context 'irregular capitalization' do
+    specify { expect(Feature).to be_enabled(:file_s3, user: user) }
+    specify { expect(Feature::FileS3).to be_enabled_for(user: user) }
+    specify { expect(Feature).not_to be_disabled(:file_s3, user: user) }
+    specify { expect(Feature::FileS3).not_to be_disabled_for(user: user) }
+    specify { expect(Feature).to be_disabled(:file_s3, user: widget) }
+  end
+end