Skip to content

HttpClient.followRedirects is misleading #6231

@tmcw

Description

@tmcw

What version of Effect is running?

3.21.0

What steps can reproduce the bug?

Effect provides a method HttpClient.followRedirects() that appears to configure whether the client should follow a number of redirects. But FetchHttpClient has no RequestInit options, so it automatically follows redirects, making followRedirects a noop.

What is the expected behavior?

It's hard to tell what the expected behavior is because the FetchHttpClient has no documentation, but ideally it would not be possible to write this kind of misleading code.

What do you see instead?

Redirect following would be detected in the client provided, or controlled from the option per-request.

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions