Repository navigation
Fix MCP 2026-07-28 listings failing for resources, templates and prompts registered as plain objects - #10244
Merged
tim-smart merged 3 commits intoNov 1, 2026
Conversation
🦋 Changeset detectedLatest commit: ce57b91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the 2026-07-28 protocol,
resources/list,resources/templates/listandprompts/listfail with-32603 MCP feature handler failedwhen a resource, template or prompt was registered as a plain object through theMcpServerservice:One such registration hides every resource. Resources and templates listed fine in 4.1.0; prompts already failed there.
#10082 changed the 2026-07-28 projections to
McpProtocol.transcode(PublicMcpSchema.Resource, …)(and likewise for templates), and prompts already worked that way. These public schemas areSchema.Class, so encoding rejects anything that is not an instance.addResource,addResourceTemplateandaddPromptstore what they are given, unlikeaddTool, which normalizes withnew McpTool(...), and the older protocol adapters accept plain objects.The projections now encode by the classes' fields, with
iconsencoded by theIconfields as well, sinceIconis also a class.AnnotationsandPromptArgumentare opaque structs and already accept plain objects. Instances encode as before, and optional fields given asundefinedare still dropped. The test registers a plain resource, template and prompt, each with a plain icon, and lists them on 2026-07-28.Closes EFF-3252