Skip to content

fix: floor TestClock nanoseconds before BigInt conversion#6194

Merged
tim-smart merged 2 commits into
mainfrom
fix/test-clock-bigint-conversion
Apr 22, 2026
Merged

fix: floor TestClock nanoseconds before BigInt conversion#6194
tim-smart merged 2 commits into
mainfrom
fix/test-clock-bigint-conversion

Conversation

@mikearnaldi
Copy link
Copy Markdown
Member

@mikearnaldi mikearnaldi commented Apr 21, 2026

Summary

  • floor fractional millisecond instants before converting TestClock nanoseconds to BigInt
  • add a regression test covering a fractional millisecond timestamp that previously threw RangeError
  • add a patch changeset for the effect package

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Apr 21, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

🦋 Changeset detected

Latest commit: a8ca4a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/workflow Patch
@effect/ai Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-google Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/effect/test/TestClock.test.ts Outdated
@tim-smart tim-smart enabled auto-merge (squash) April 22, 2026 22:39
@tim-smart tim-smart merged commit 74f3267 into main Apr 22, 2026
11 checks passed
@tim-smart tim-smart deleted the fix/test-clock-bigint-conversion branch April 22, 2026 22:44
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Apr 22, 2026
@github-actions github-actions Bot mentioned this pull request Apr 22, 2026
Hoishin added a commit to Hoishin/effect that referenced this pull request May 18, 2026
* upstream/main: (126 commits)
  fix(@effect/cli): use Ansi.blackBright for Weak spans so --help is readable on dark terminals (Effect-TS#6208)
  fix(cli): replace all hyphens in shell completion command names (Effect-TS#6213)
  Version Packages (Effect-TS#6218)
  Support null K8s lastTransitionTime values (Effect-TS#6217)
  Version Packages (Effect-TS#6197)
  Backport workflow suspension failure fixes (Effect-TS#6196)
  clone full v4 history
  Version Packages (Effect-TS#6195)
  preserve fiber context in HttpLayerRouter.addHttpApi so API-level middleware is applied (Effect-TS#6147)
  correct typos in source code (receive, separate) (Effect-TS#6110)
  docs(@effect/vitest): fix return type in fails example (Effect-TS#6163)
  make RpcSerialization.msgPack options configurable (Effect-TS#6161)
  update msgpackr to 1.11.10 for Cloudflare Workers compatibility (Effect-TS#6191)
  fix: floor TestClock nanoseconds before BigInt conversion (Effect-TS#6194)
  chore: disable TypeScript's nightly workflow (Effect-TS#6193)
  Version Packages (Effect-TS#6189)
  (fix: ai-openai) Remove strict param from the OpenAI request body (Effect-TS#6188)
  Version Packages (Effect-TS#6142)
  fix(ai-openai): deduplicate response.output items to prevent invalid JSON concatenation (Effect-TS#6178)
  Change 'in-memory' to 'in_memory' in prompt cache enums (Effect-TS#6187)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants