feat(Tabs): Add dropdown in tab #1087
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Description:
This PR implements dropdown functionality in the Tabs component, allowing tabs to contain dropdown menus with selectable sub-items. The changes include new TypeScript types for dropdown items, state management for dropdown interactions, styling updates for dropdown indicators, and comprehensive accessibility features including ARIA attributes and keyboard navigation. The implementation is thoroughly tested and documented with new storybook examples. 1
Click For Summary of Files
Summary of Files
Files Modified
src/components/Tabs/tabs.module.scss
Updated tabs styling to support dropdown functionality and improve RTL support:
- Restructured first-child tab styling to work with both direct tabs and dropdown-wrapped tabs
- Added dropdown chevron styling with animation and RTL support
- Implemented focus-visible styling for dropdown menu buttons
src/components/Tabs/Tabs.types.ts
Added dropdown functionality support to Tabs component types:
- Added TabVariantType enum and TabDropdownItem interface to support dropdown tabs
- Extended TabProps interface with dropdown configuration options including placement and trigger modes
- Included accessibility properties (ariaLabel) and interaction states (disabled) for dropdown items
src/components/Tabs/Tabs.test.tsx
Added comprehensive test coverage for new dropdown functionality in Tabs component:
- Implemented core dropdown functionality tests covering rendering, interactions, and state management
- Added accessibility testing for ARIA attributes and keyboard navigation
- Created test cases for dropdown behaviors including hover states, item selection, and disabled items
src/components/Tabs/Tab/Tab.tsx
Implement dropdown functionality for Tabs component:
- Added dropdown support with hover trigger and menu overlay
- Enhanced tab active state to consider both direct and dropdown item selections
- Improved accessibility with additional ARIA attributes and keyboard navigation
- Implemented dropdown UI with chevron indicator and state management
src/components/Tabs/Tabs.stories.tsx
Added dropdown functionality demonstration to Tabs component stories:
- Created new story "With_Dropdown" showcasing tabs with dropdown capabilities
- Added dropdown tab configuration with three sub-items, including disabled state support
- Extended tab configuration to support dropdown variant type and maintain accessibility features
Tips
Review Droid is highly customizable and comes with powerful features for augmenting your organization's code review process. Here are some tips to get the most out of it.
Table of contents
- Droid Fill - Contextual PR Body Replacement
- Review Guidelines - Creating guidelines for Droid to enforce
- Droid Chat - Follow up with Droid's Comments
- PR Healing - Diagnose & Fix Failures in CI
- Teaching Droid - Giving Droid feedback so it learns
- Review Usage
⌨️ Droid Fill
Contextual PR Body Replacement
When you create a PR with the @droid fill command anywhere in your PR body, Review Droid will fill in the PR description for your pull request based on it's PR analysis. This will also take into account your pull request templates.
Review Droid can also analyze your project management system. If you have a project management system integrated with Factory (e.g. Linear, Jira) Review Droid will also integrate information from linked and related tickets.
At Factory, we typically create our PR's with this command. For example, let's say I'm creating a PR which addresses the jira ticket FAC-123. I would write the following PR description:
@droid fill FAC-123
and your Review Droid fills in the rest!
📚 Review Guidelines
Creating guidelines for Droid to follow
You can configure guidelines that Droid will follow when reviewing your PRs. Droid will focus on these aspects of your code and aim to leave in-line comments if any guidelines are violated.
Guidelines are defined in your repository's .droid.yaml. Every week, Droid will automatically refine and edit these guidelines based on the feedback you leave on Droid's comments.
💬 Droid Chat
Ask questions on a PR
You can leave in-line comments on PR's by tagging @droid in-line. This can be helpful when reviewing other's PRs. Some examples include:
@droid this section looks sketchy, are there issues with it?@droid can you show me some examples of what this regex matches?@droid is this the most efficient way to do this? I'm concerned about performance.
Follow up with Review Droid's Comments
You can reply to Review Droid's in-line review comments directly to ask questions or provide feedback. Some examples include:
@droid I made the change you suggested, does that fix the issue?@droid we don't actually need to do this because of X, Y, Z. Can you confirm?@droid do we have any scripts that rely on this behavior?
🛠️ PR Healing
Diagnose & Fix Failures in CI
Review Droid is aware of the CI processes you utilize and proposes fixes in case of any failures. This allows it to promptly address issues in your pull requests before they escalate.
By default, PR Healing is activated. Your organization does not have advanced PR healing enabled, which involved Review Droid directly making a PR to your PR which fixes the issue. If you would like to enable this feature, you must have an Enterprise Plan.
🎓 Teaching Droid
Giving Droid feedback so it learns
You can give feedback to Review Droid by replying or reacting to its comments (👍 / 👎). This helps Review Droid learn from your preferences and improve its future reviews.
To send feedback directly to the Factory team, include @droid feedback in your comment. Droid will file a ticket with your feedback and provide a ticket ID so you can track it with our support team.
🔎 Review Usage
Re-Requesting Review
If you make changes to your PR and want Review Droid to re-review it, you can simply comment @droid review on the PR. This will trigger Droid to re-review the PR and update the review body.
.droid.yaml to Configure Review Droid
You can place a .droid.yaml file in the root of your repository. This file contains settings for a variety of features and settings including:
- Guidelines - For defining the rules that Review Droid will enforce
- Enabling/Disabling Per-file Summaries
- Enabling/Disabling PR Healing
- Path Filters (For ignoring certain files or directories)
- Auto-Review Settings
- Chat settings
To override a setting leave a comment on a PR with the setting to disable/enable/reset. For example @droid setting disable progress_comment. The current options are: progress_comment, lgtm_comment, and list.
list is a special setting that will list all the settings that you have set and will explain what each setting does.
For more information, you can view our documentation at https://docs.factory.ai - the password is factory.
Ignoring Reviews
If you want to have your PR ignored by Review Droid you can define Droid Ignored Title Words in your .droid.yaml file. If the title of your PR contains any of these words, Review Droid will ignore the PR.
Your organization currently has the following words in the Droid Ignored Title Words list:
None
Footnotes
-
React 👍 / 👎 to comments you like / dislike. Droid will learn from this feedback to leave better reviews. My in-line comments are based on your review guidelines. If you have any questions about the comments, reply to them with @droid ↩
ychhabra-eightfold
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
+ Coverage 84.02% 84.07% +0.05%
==========================================
Files 1146 1146
Lines 21108 21134 +26
Branches 8021 8034 +13
==========================================
+ Hits 17735 17768 +33
+ Misses 3285 3279 -6
+ Partials 88 87 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
shipit |
SUMMARY:
Add dropdown in dropdown
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-178186
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Screen.Recording.2026-01-06.at.2.40.55.PM.mov