This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Open
Conversation
2e8740e to
cca7b0c
Compare
Member
Author
|
I have added lines at y=0 and x=0 to indicate where the origin is on the map. |
Contributor
|
jenkins build please |
Member
Author
|
jenkins build please |
andreicristian97
approved these changes
Apr 3, 2024
Contributor
andreicristian97
left a comment
There was a problem hiding this comment.
Looking at the code seems good, did not test it locally.
Noted one small typo in doc.
| - The user sees a variable scale coordinate grid with 1 meter, 10 meter and 10 centimeter spacings depending on the current map scale. | ||
| - A yard stick displays the current scale of the coordinate grid. | ||
| - The origin point is marked on the map. | ||
| - The grid can be toggled on and of using a button in the top right toolbar. |
Contributor
There was a problem hiding this comment.
Typo, in "on and of", should be "off"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Basics
close #X, are in the commit messages and changelog.Checklist
Review