Conversation
389ccba to
ef9ee61
Compare
…lektraInitiative/PermaplanT into 1122-drawingLayer-fillPatterns
…lektraInitiative/PermaplanT into 1122-drawingLayer-fillPatterns
|
please add a summary :) |
|
I fixed the migrations =) |
frontend/src/features/map_planning/layers/drawing/DrawingLayerLabelCreationForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Works really great for me, good work! See comments I made for some minor issues I found.
- I've tested the code
- I've read through the whole code
- I've read through the whole documentation
- I've checked conformity to guidelines
- I've checked conformity to requirements
- I've checked that the requirements are tested
frontend/src/features/map_planning/layers/drawing/labels/EditableTextinput.tsx
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| export function generatePointsPatternAsImage(color: string) { | ||
| const svgString = `<svg width="100" height="100" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Is there a specific reason why you hard coded this svg data?
I would prefer it if you saved it to its own file, importing it like we do with our icons.
This would make it easier to edit fill patterns in the future, especially for non-technical team members such as @yvonnemarkl.
There was a problem hiding this comment.
you are right, i also don't really like the current solution.
i had some struggles with importing the svg and then create a html image as konva is expecting.
However, I will take a further look into this.
db7bbf1 to
7df9a03
Compare
|
jenkins build please |
1 similar comment
|
jenkins build please |

Basics
close #X, are in the commit messages and changelogChecklist
First Time Checklist
Review