This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Return 409 conflict when POST /maps with taken name. close #758#1298
Open
Return 409 conflict when POST /maps with taken name. close #758#1298
Conversation
Contributor
Author
|
jenkins build please |
markus2330
suggested changes
Apr 19, 2024
Contributor
markus2330
left a comment
There was a problem hiding this comment.
Great work! CI did not run through and not enough reviews here yet, though.
chr-schr
approved these changes
Apr 19, 2024
Contributor
chr-schr
left a comment
There was a problem hiding this comment.
Looks good to me for the backend 👍
But the frontend should display the specific error message instead of a generic one.

I suggest to update #758 and add a frontend task or create a left over issue.
- I've tested the code
- I've read through the whole code
- I've read through the whole documentation
- I've checked conformity to guidelines
- I've checked conformity to requirements
- I've checked that the requirements are tested
Contributor
Contributor
|
jenkins build please |
Closed
c180740 to
886a9c4
Compare
danielsteinkogler
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return 409 conflict when creating a new map with existing name instead of a 500 server error.
Also add a simple regression test.
Basics
close #X, are in the commit messages and changelogChecklist
First Time Checklist
Review