Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
(I think) Closes #57
Adds in two methods to the API,
void ResetCauseOfDeath(int playerId)andvoid ResetCauseOfDeath(PlayerControllerB player).SetCauseOfDeathis unchanged aside from wording in the summary. Currently, ifnullis passed toSetCauseOfDeaththen it will still correctly be rejected, asforceOverridewill never be true.The only issue I can forsee is that if there are existing mods that hook into
AdvancedDeathTrackerwithout using the public API, the issue you mentioned about accidentally passing null could arise. This would still requireforceOverrideto be true.This could be rectified by more extensively editing existing functionality, like straight up having a separate Rpc for
ResetCauseOfDeathto call, however I'm unsure if any mods DO use the privateAdvancedDeathTrackerin that way so I figured it would be best to preserve existing code as much as possible. Let me know if you want me to find another way instead though.I also need to do more testing just to make sure this works as expected, so will leave as a draft PR until I do so - but please let me know of any changes you'd want in the meantime in order to accept.