Lint [workspace.dependencies]#673
Merged
Jake-Shadle merged 8 commits intomainfrom Jun 26, 2024
Merged
Conversation
Jake-Shadle
force-pushed
the
workspace-duplicate-lint
branch
from
7a71f17 to
161812a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new lints:
workspace-duplicates- Will be triggered if >1 direct workspace dependencies that resolve to the same crate are not using a shared[workspace.dependencies]entryunused-workspace-dependency- Will be triggered if a workspace dependency is not actually usedThis also improves the output for the
wildcardslint to show the span information for the actual crate manifest where the wildcard dependency is declared, rather than the synthesized one used previous to this change.Resolves: #436
Resolves: #525