Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Add ignore and no_run to get cargo test to pass.#1101

Merged
fornwall merged 3 commits into
EmbarkStudios:mainfrom
LegNeato:doc_failure
Jan 24, 2024
Merged

Add ignore and no_run to get cargo test to pass.#1101
fornwall merged 3 commits into
EmbarkStudios:mainfrom
LegNeato:doc_failure

Conversation

@LegNeato

Copy link
Copy Markdown
Contributor

Without these running cargo test on a clean checkout fails.

@LegNeato LegNeato requested a review from eddyb as a code owner November 27, 2023 02:11

@eddyb eddyb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a CHANGELOG entry, and also make sure we run all the tests on CI, so this gets hit?

Ideally you could do it in a commit before the fixes, and push that commit first, such that we can see CI fail before the fix (so we know the CI changes can reproduce).

@LegNeato

Copy link
Copy Markdown
Contributor Author

@eddyb done. I debated using --doc and/or using -p on each of the crates instead of doing the entire cargo test, but this was the "safest" as it would catch any issues.

@LegNeato LegNeato requested a review from eddyb December 17, 2023 21:15
@fornwall fornwall requested review from fornwall and removed request for eddyb January 24, 2024 11:55

@fornwall fornwall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fornwall fornwall enabled auto-merge (squash) January 24, 2024 11:55
@fornwall fornwall disabled auto-merge January 24, 2024 11:55
@fornwall fornwall merged commit f955221 into EmbarkStudios:main Jan 24, 2024
@LegNeato LegNeato deleted the doc_failure branch January 24, 2024 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants