This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add primitive set of arch instructions#520
Merged
Merged
Conversation
khyperia
approved these changes
Mar 22, 2021
khyperia
left a comment
khyperia
left a comment
Contributor
There was a problem hiding this comment.
This looks good, but we should probably focus on more important things - geometry shaders are not on the roadmap any time soon.
Member
Author
Yep of course. I'm currently blocked on a fix for an ICE landing on nightly for the Image PR so I was working on other instructions and this seemed easy to do and complete. What else would be required to support geometry? AFAICT these are the only geometry specific instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were small enough to just add.