Upgrade to commons 3.0.2 and UFC API (FF-2098)#46
Merged
Conversation
leoromanovsky
force-pushed
the
lr/ff-2098/ufc
branch
2 times, most recently
from
c1f2b83 to
89e2e91
Compare
leoromanovsky
force-pushed
the
lr/ff-2098/ufc
branch
from
15573c1 to
00471de
Compare
aarsilv
approved these changes
May 16, 2024
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| node-version: '18.x' # Specify the Node.js version directly here |
| { | ||
| "name": "@eppo/react-native-sdk", | ||
| "version": "1.1.0", | ||
| "version": "3.0.0", |
| }, | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "2.2.0", | ||
| "@eppo/js-client-sdk-common": "3.0.2", |
| }); | ||
|
|
||
| it('returns null when experiment config is absent', () => { | ||
| it('returns default value when experiment config is absent', () => { |
| import { EppoAsyncStorage } from './async-storage'; | ||
| import AsyncStorage from '@react-native-async-storage/async-storage'; | ||
|
|
||
| describe('EppoAsyncStorage', () => { |
| import AsyncStorage from '@react-native-async-storage/async-storage'; | ||
|
|
||
| describe('EppoAsyncStorage', () => { | ||
| const storageKey = '@eppo/sdk-cache-ufc'; |
Contributor
There was a problem hiding this comment.
With Android, we encountered users encountering issues changing up API keys on devices. I wonder if we should also make react native storage isolated per API key.
Contributor
There was a problem hiding this comment.
Also, should this just be STORAGE_KEY?
|
|
||
| export class EppoAsyncStorage implements IConfigurationStore { | ||
| private cache: { [key: string]: any } = {}; | ||
| private _isInitialized = false; |
Contributor
There was a problem hiding this comment.
Same as other repo--how come we are using underscore prefix?
Member
Author
There was a problem hiding this comment.
Conflicts with the public method.
Contributor
There was a problem hiding this comment.
🤦 ah that makes sense! Carry on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
upgrade react-native to the new UFC format and take advantage of upcoming feature releases.
description
axios. However it does not include changes to the configuration store. We will wait until those are accepted intojs-browserrepo to make those changes here.initfunction matchesjs-clientexcept not polling configuration - is this needed?js-commonsdoesn't need to be repeated heretesting
running local ios and android simulators