This repository was archived by the owner on Nov 19, 2025. It is now read-only.
feat: use list for example prompts#2117
Merged
DavidSpriggs merged 1 commit intomasterfrom Nov 12, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 01bf3ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request updates how example prompts are managed in the Hub Assistant configuration, switching from a simple array of strings to a list of keyed objects with labels. This enables more flexible editing and better UI support. The changes include schema updates, transformation logic in the
HubSiteclass, UI schema adjustments, and new tests to ensure correct behavior.Hub Assistant example prompts improvements
HubItemEntitySchemaso thatassistant.examplePromptsis now an array of objects, each with akeyand alabel, instead of an array of strings. (packages/common/src/core/schemas/shared/HubItemEntitySchema.ts)HubSite.toEditorandHubSite.fromEditorto convert between string arrays and object arrays forexamplePrompts, ensuring compatibility between storage and editing formats. (packages/common/src/sites/HubSite.ts)Testing and coverage
examplePrompts, ensuring round-trip integrity. (packages/common/test/sites/HubSite.spec.ts,packages/common/test/sites/_internal/SiteUiSchemaAssistant.spec.ts)Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
Either ran
npm run changesetor this change does not require a release.These changes have been verified by QA using a
?uiVersionthat includes a PR-Preview of this branch and thev_reqlabel has been applied to the issue.OD-UI E2E tests pass against these changes using a
?uiVersionthat includes a PR-Preview of this branch