Merged
Conversation
Octol1ttle
previously approved these changes
Oct 3, 2020
mbax
previously approved these changes
Oct 3, 2020
mbax
previously approved these changes
Oct 4, 2020
mbax
previously approved these changes
Oct 4, 2020
darbyjack
previously approved these changes
Oct 4, 2020
# Conflicts: # Essentials/src/com/earth2me/essentials/commands/Commandbalancetop.java
darbyjack
previously approved these changes
Oct 5, 2020
Member
darbyjack
left a comment
darbyjack
left a comment
There was a problem hiding this comment.
I've reviewed this PR and deem it to be worthy of merging. Thank you for taking the time to work with me and implementing this feature. This should be a big help to anyone who uses the Essentials api.
mbax
suggested changes
Oct 6, 2020
Essentials/src/com/earth2me/essentials/commands/Commandbalancetop.java
Outdated
Show resolved
Hide resolved
mbax
previously approved these changes
Oct 6, 2020
HexedHero
previously approved these changes
Oct 7, 2020
darbyjack
previously approved these changes
Oct 17, 2020
mdcfe
requested changes
Dec 2, 2020
Essentials/src/main/java/com/earth2me/essentials/Essentials.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/net/essentialsx/api/v2/services/BalanceTop.java
Outdated
Show resolved
Hide resolved
Proximyst
suggested changes
Dec 4, 2020
Essentials/src/main/java/com/earth2me/essentials/commands/Commandbalancetop.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/BalanceTopImpl.java
Outdated
Show resolved
Hide resolved
…andbalancetop.java Co-authored-by: Mariell <proximyst@proximyst.com>
TehBrian
reviewed
Dec 4, 2020
mdcfe
requested changes
Jan 19, 2021
Essentials/src/main/java/com/earth2me/essentials/BalanceTopImpl.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/net/essentialsx/api/v2/services/BalanceTop.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
# Conflicts: # Essentials/src/main/java/net/essentialsx/api/v2/package-info.java # Essentials/src/main/java/net/essentialsx/api/v2/services/package-info.java
mdcfe
reviewed
Feb 15, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandbalancetop.java
Outdated
Show resolved
Hide resolved
…andbalancetop.java Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
mdcfe
approved these changes
Feb 15, 2021
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Co-authored-by: Mariell <proximyst@proximyst.com> Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com> This moves storage of balances from the baltop command into the UserMap. This was needed by Glare to able to get a hold of all users balances without causing jvm hell on the usermap. To access this API as an end user; ```java import net.essentialsx.api.v2.services.BalanceTop; //... BalanceTop api = Bukkit.getServer().getServicesManager().load(BalanceTop.class); ``` Closes EssentialsX#3100, closes EssentialsX#3540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves storage of balances from the baltop command into the UserMap. This was needed by Glare to able to get a hold of all users balances without causing jvm hell on the usermap.
To access this API as an end user;
Closes #3100
Closes #3540