Merged
Conversation
JRoy
added
type: bugfix
TODO: I NEED TO ADD SPECIAL ARMOR SLOT PARSING TO Inventories#parseInventoryData because otherwise we dismiss slots too early for the space calculations :(
This makes sure armor is added to armor slots first during Inventories#addItem to ensure space is utilized as best as possible.
JRoy
changed the title
Member
Author
|
ready for review, needs testing with all commands/features that touch items. |
pop4959
reviewed
Aug 22, 2022
Member
pop4959
left a comment
pop4959
left a comment
There was a problem hiding this comment.
Just a few notes on initial look-through
Essentials/src/main/java/com/earth2me/essentials/craftbukkit/Inventories.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/craftbukkit/Inventories.java
Outdated
Show resolved
Hide resolved
Member
|
Tested commands: Didn't test keep inventory policy or trade/enchant signs yet. Looks good so far though, didn't find any issues with any commands. |
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java
pop4959
approved these changes
Oct 15, 2022
Member
|
Still haven't tested the things above, but assuming those are ok this PR looks good to me |
mdcfe
reviewed
Dec 24, 2022
Member
mdcfe
left a comment
mdcfe
left a comment
There was a problem hiding this comment.
Looks good, just a couple of things to note.
Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java
Show resolved
Hide resolved
mdcfe
approved these changes
Dec 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are a LOT of weird inventory stuff going on in EssX.
Fixes #3810
Fixes #4248
maybe more inventory issues that I'm unable to find?