Skip to content

Fix inaccurate online player count for Discord leave message #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdcfe merged 2 commits into from
Jul 23, 2023
Merged

Fix inaccurate online player count for Discord leave message #5440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
671260c
Fix inaccurate online player count for Discord leave message
JRoy Jul 23, 2023
bdae028
mdcfe review
JRoy Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/BukkitListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public void onVanishStatusChange(VanishStatusChangeEvent event) {
}

public void sendJoinQuitMessage(final Player player, final String message, MessageType type) {
int userCount = jda.getPlugin().getEss().getUsers().getUserCount();
int onlineCount = jda.getPlugin().getEss().getOnlinePlayers().size();
final MessageFormat format;
switch (type.getKey()) {
case "join":
Expand All @@ -130,7 +130,7 @@ public void sendJoinQuitMessage(final Player player, final String message, Messa
break;
default: // So that it will always be initialised. Other options shouldn't be possible.
format = jda.getSettings().getQuitFormat(player);
userCount = userCount - 1;
onlineCount = onlineCount - 1;
break;

}
Expand All @@ -139,8 +139,8 @@ public void sendJoinQuitMessage(final Player player, final String message, Messa
MessageUtil.sanitizeDiscordMarkdown(player.getName()),
MessageUtil.sanitizeDiscordMarkdown(player.getDisplayName()),
MessageUtil.sanitizeDiscordMarkdown(message),
jda.getPlugin().getEss().getOnlinePlayers().size(),
userCount),
onlineCount,
jda.getPlugin().getEss().getUsers().getUserCount()),
player);
}

Expand Down