Investigate workflow job failing on main: lint / ESLint check

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: lint / ESLint check
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @ryntgh
• 🤝 Merged by: @carlosmiceli
• 🐛 Error Message:
  warning: Cache save failed.
  failure: Process completed with exit code 1.
  warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
  warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
  warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
  warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
  warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
  warning: The 'transactionIDSet' object construction makes the dependencies of useCallback Hook (at line 47) change on every render. To fix this, wrap the initialization of 'transactionIDSet' in its own useMemo() Hook
  warning: React Hook useMemo has a missing dependency: 'allPolicies'. Either include it or remove the dependency array
  warning: The 'measure' function makes the dependencies of useEffect Hook (at line 117) change on every render. To fix this, wrap the definition of 'measure' in its own useCallback() Hook
  warning: The 'measure' function makes the dependencies of useLayoutEffect Hook (at line 109) change on every render. To fix this, wrap the definition of 'measure' in its own useCallback() Hook
  warning: React Hook useMemo has a missing dependency: 'expensifyIcons'. Either include it or remove the dependency array

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named lint / ESLint check.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

[khushi0433]

Proposal
What problem is this issue trying to solve?

The lint / ESLint check workflow is currently failing due to deprecated Onyx.connect() usage in multiple utility files, along with React hook dependency warnings. While these issues don’t cause runtime bugs, they block CI and prevent new changes from being merged safely.

The goal of this fix is to remove deprecated API usage and bring the affected code back into ESLint compliance without changing behavior.

What is the root cause?

There are two main problems:

1. Deprecated Onyx.connect() in utility files

Several files under src/libs/ are pure utility modules, but they still use Onyx.connect(). This API is now deprecated and intended for React components only. ESLint flags this usage correctly.

In utility files, Onyx.connectWithoutView() should be used instead.

2. React hook dependency issues

Some components create objects or functions inside the render body and then use them inside hooks such as useCallback, useEffect, or useMemo. This causes unstable dependencies or missing dependency warnings, which ESLint treats as failures.

What changes should be made to fix this?

The fix should be minimal and focused:

Replace Onyx.connect() with Onyx.connectWithoutView() in non-React files

Keep existing logic and data flow unchanged

Stabilize hook dependencies using useMemo and useCallback

Update dependency arrays where required

No business logic or UI behavior should change.

Concrete changes
Replace deprecated Onyx.connect() usage

Before (deprecated):

Onyx.connect({
    key: ONYXKEYS.COLLECTION.REPORT,
    callback: (reports) => {
        reportMap = reports;
    },
});

After (correct for utility files):

Onyx.connectWithoutView({
    key: ONYXKEYS.COLLECTION.REPORT,
    callback: (reports) => {
        reportMap = reports;
    },
});

This keeps behavior identical while removing the deprecated API usage.

• Fix unstable hook dependencies

Before (unstable dependency):

const filters = {policyID, type};

const handleSearch = useCallback(() => {
    submitSearch(filters);
}, [filters]);

After (stable dependency):

const filters = useMemo(() => ({policyID, type}), [policyID, type]);

const handleSearch = useCallback(() => {
    submitSearch(filters);
}, [filters]);

• Fix missing dependencies in hooks

Before:

const memoizedValue = useMemo(() => {
    return computeSomething(allPolicies);
}, []);

After:

const memoizedValue = useMemo(() => {
    return computeSomething(allPolicies);
}, [allPolicies]);

Scope of this change
Only utility and hook-related fixes
No functional or behavioral changes
No UI changes
ESLint-focused cleanup
Changes kept small and reviewable
Validation plan
Run npm run lint-changed locally
Confirm no new warnings are introduced
Verify lint / ESLint check passes in CI

Alternative solutions considered

Disabling ESLint rules: rejected to avoid technical debt
Ignoring deprecated API warnings: rejected since this will break future upgrades

[melvin-bot]

📣 @khushi0433! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[khushi0433]

Contributor details
Your Expensify account email: khushbubaloch01+@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01626b34fb15c459c0

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!