Skip to content

[CFI] NEW FEATURE: Allow admins to mark report with non-reimbursable expenses as paid #81721

@m-natarajan

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.15-2
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and link from BrowserStack:**
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
**Expensify/Expensify Issue URL:

**Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Create a report with only non-reimbursable expenses on a workspace with payments enabled.
  2. Submit the report and approve it as an admin.

Expected Result:

The admin sees the pay button. If they try to pay it via ACH, we should throw an error explaining the report only has non-reimbursable expenses so it can't be paid via ACH. If they try to mark it as paid, allow that. This is how Expensify Classic handles this exact scenario.

Actual Result:

We don't show the pay button in NewDot on a report that only has non-reimbursable expenses, even if payments are enabled.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Recording.2359.mp4

View all open jobs on GitHub

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Status

HIGH

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions