-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Due for payment 2026-03-19] Add reasonAttributes to ReportHeaderSkeletonView usage sites #83398
Copy link
Copy link
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionEngineeringTaskWeeklyKSv2KSv2
Description
Problem
As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.
Solution
Add reasonAttributes to all usage sites of ReportHeaderSkeletonView (src/components/ReportHeaderSkeletonView.tsx).
At each usage site:
- Pass a
reasonAttributesprop with acontextstring identifying the parent component (e.g.'ParentComponent.ChildComponent') - Include relevant boolean state variables that determine the loading state (e.g.
isLoading,isDataReady)
Example
const reasonAttributes: SkeletonSpanReasonAttributes = {
context: 'ParentComponent',
isLoading,
isDataReady,
};
<ReportHeaderSkeletonView reasonAttributes={reasonAttributes} />Reference
- See PR #82927 as an example of how this was done for
ActivityIndicatorin image-loading contexts - Parent issue: Track loading state conditions in Sentry spans to debug infinite skeletons #81683
Scope
- Component path:
src/components/ReportHeaderSkeletonView.tsx - Usage sites to update: ~6 files
Issue Owner
Current Issue Owner: @sosek108Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionEngineeringTaskWeeklyKSv2KSv2