Expense - Default Custom Tax Name Displays Incorrectly as “Tax rate” in Multiple Expense Edit

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.34-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82948
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

Pre-condition

1. Have workspace

2. Enable category, tag ( add 2 tags), tax, rules

3. Create 2 distance manual map expense

4. Launch app

5. Go to workspace settings

6. Open tag - settings (note default custom tag name)

7. Open tax - settings (note default custom tax name)

8. Open workspace chat

9. Select both expenses - edit multiple

10. Open tag and tax row

11. Note default custom tag name is shown correctly but tax name is shown incorrectly as "Tax rate" instead "Tax"

12. Go to workspace settings - rules - add a merchant rule

13. Open Tax row

14. Note default custom tax name is shown correctly as "Tax"

Expected Result:

The default custom tax name configured in workspace settings should be displayed consistently as “Tax” in all relevant places, including Multiple Expense Edit.

Actual Result:

In multiple expense edit → Tax row, the default custom tax name is displayed incorrectly as “Tax rate” instead of “Tax”.
However, in merchant rule → Tax row, the default custom tax name is displayed correctly as “Tax”.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #82948

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #82948 - "Reapply "Feat: bulk edit multiple"" by @pasyukevich (High confidence)
Related Issues: None

Recommendation: REVERT

This PR introduced the bulk edit multiple feature and included hardcoded tax field labels that do not respect the workspace custom tax name configuration.

Labels: Keeping DeployBlockerCash (App deploy blocker). The DeployBlocker label was not present on this issue, so no label removal is needed.

📋 Detailed Analysis

Evidence

The issue was introduced by PR #82948, which added the bulk edit multiple feature. The bot comment confirms this PR was merged and is the likely cause. The bug is reproducible on staging (version 9.3.34-0) where this PR is included, and not yet in production.

Verification

The PR added two files that contain the bug:

1. src/pages/Search/SearchEditMultiple/SearchEditMultiplePage.tsx (line 224):

description: translate(\"iou.taxRate\"),  // Returns "Tax rate"

2. src/pages/Search/SearchEditMultiple/SearchEditMultipleTaxPage.tsx (line 59):

title={translate(\"iou.taxRate\")}  // Returns "Tax rate"

Both locations use the hardcoded translation key iou.taxRate which always returns "Tax rate", instead of using the custom tax name configured in the workspace settings.

Root Cause

The custom tax name is stored in policy.taxRates.name (as seen in WorkspaceTaxesSettingsPage.tsx line 34). The correct pattern used elsewhere in the codebase is:

policy?.taxRates?.name ?? translate(\"common.tax\")

This would display the custom tax name (e.g., "Tax", "Imposto", "VAT") when configured, falling back to "Tax" when not customized.

The merchant rule page likely uses the correct pattern, which is why it displays "Tax" correctly as mentioned in the bug report.

Fix Required

Update both files to use policy?.taxRates?.name ?? translate(\"common.tax\") instead of translate(\"iou.taxRate\").