Fix incorrect order of chats in LHN when concierge task status changes to complete or incomplete#78452
Conversation
…s to complete or incomplete Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
|
@abdulrahuman5196 PR is ready |
trjExpensify
left a comment
There was a problem hiding this comment.
Agree that marking a task within a chat as complete/incomplete shouldn't reorder the chat position in the LHN. 👍
|
Friendly bump @abdulrahuman5196 |
1 similar comment
|
Friendly bump @abdulrahuman5196 |
|
Checking now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-19.at.9.34.44.PM.movAndroid: mWeb ChromeScreen.Recording.2026-01-19.at.9.36.22.PM.moviOS: HybridAppScreen.Recording.2026-01-19.at.9.26.39.PM.moviOS: mWeb SafariScreen.Recording.2026-01-19.at.9.27.36.PM.movMacOS: Chrome / SafariScreen.Recording.2026-01-19.at.6.23.30.PM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @dangrous
🎀 👀 🎀
C+ Reviewed
|
@dangrous I have merged main, The ESLint check error is not caused by this PR. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.6-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀
|
Fix incorrect LHN chat orders when report
requiresAttentionchanges.Explanation of Change
Fixed Issues
$ #74363
PROPOSAL: #74363 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native_d.mp4
Android: mWeb Chrome
android_mweb_d.mp4
iOS: Native
ios_native_d.mp4
iOS: mWeb Safari
ios_msafari_d.mp4
MacOS: Chrome / Safari
macos_web_d.mp4