Fix filtering attendees names in the `Reports` page by lakchote · Pull Request #79498 · Expensify/App

lakchote · 2026-01-13T16:33:41Z

Explanation of Change

Allows filtering by attendees name in the Reports page.

Screen.Recording.2026-01-13.at.16.53.30.mov

Fixed Issues

$ #79422
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Prerequisite: Account has at least one workspace.
Prerequisite 2: "Rules" and "Attendee Tracking" enabled.

Open the Expensify app.
Open workspace chat.
Click + > Create expense > Manual.
Enter amount > Next.
On confirm page, click Attendee field.
Enter name (not email), select it and save it.
Finish the expense creation flow.
Navigate to "Reports" > "Expenses"
Tap on "Filters" and select the "Attendee" filter.
Note that a list with attendees to select is displayed, but the attendee added with a name, can´t be found.

Expected Result:
Attendee added to an expense with a name, should be visible on the list displayed when trying to apply "Attendee" filter on "Reports".

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as in tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-01-13T16:42:21Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/OptionsListUtils/index.ts	`76.65% <100.00%> (+1.60%)`	⬆️
src/libs/SearchQueryUtils.ts	`69.68% <100.00%> (+0.04%)`	⬆️
src/libs/actions/IOU/index.ts	`67.66% <100.00%> (+0.23%)`	⬆️
...hAdvancedFiltersPage/SearchFiltersAttendeePage.tsx	`0.00% <ø> (ø)`
src/hooks/useSearchSelector.base.ts	`0.00% <0.00%> (ø)`
...pages/iou/request/MoneyRequestAttendeeSelector.tsx	`0.00% <0.00%> (ø)`
...nListWithSections/Search/UserSelectionListItem.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/AdvancedSearchFilters.tsx	`0.00% <0.00%> (ø)`
...nents/Search/SearchFiltersParticipantsSelector.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

…search

lakchote · 2026-01-14T15:20:41Z

cc @eVoloshchak if you want to take a look already

github-actions · 2026-01-16T09:57:01Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

…search

lakchote · 2026-01-19T19:10:22Z

@lakchote, TypeScript Check is failing

Should be solved now

eVoloshchak · 2026-01-19T19:29:00Z

Prettier check 😄

lakchote · 2026-01-20T06:47:14Z

@eVoloshchak now something merged to main made lint fail, see this action run for another PR: https://github.com/Expensify/App/actions/runs/21161587343/job/60857126815

eVoloshchak · 2026-01-20T11:32:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-20.at.14.41.37.mov

Android: mWeb Chrome

Screen.Recording.2026-01-20.at.13.24.34.mov

iOS: HybridApp

Screen.Recording.2026-01-20.at.13.19.37.mov

iOS: mWeb Safari

Screen.Recording.2026-01-20.at.12.29.57.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-20.at.12.01.33.mov

eVoloshchak

LGTM!

melvin-bot · 2026-01-20T13:44:45Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-20T14:37:56Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-20T14:42:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79498.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://79498.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

lakchote · 2026-01-21T06:09:46Z

@MonilBhavsar please review it when you can, thanks 🙏 !

MonilBhavsar · 2026-01-21T07:02:15Z

on it!

MonilBhavsar

Nice!
Left NAB's. Feel free to merge

MonilBhavsar · 2026-01-21T07:51:30Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

-        const selectedAccountIDs = selectedOptions.map((option) => (option.accountID ? option.accountID.toString() : undefined)).filter(Boolean) as string[];
-        onFiltersUpdate(selectedAccountIDs);
+        let selectedIdentifiers: string[];
+


Suggested change

MonilBhavsar · 2026-01-21T07:56:32Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

-                return !!option;
-            });
+        let preSelectedOptions: OptionData[];
+


Suggested change

MonilBhavsar · 2026-01-21T07:57:53Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

+                    if (!participant) {
+                        return undefined;
+                    }
+                    return getSelectedOptionData(participant);


Suggested change

if (!participant) {

return undefined;

}

return getSelectedOptionData(participant);

if (participant) {

return getSelectedOptionData(participant);

}

return undefined;

lakchote · 2026-01-21T16:58:30Z

Merging to move forward with this!

OSBotify · 2026-01-21T17:08:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-21T23:37:38Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-22T22:24:54Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

lakchote added 9 commits January 13, 2026 17:00

add shouldAcceptName option to GetOptionsConfig

946b202

fix name-only attendee filtering and deduplication

f766237

enable shouldAcceptName for attendees context

de7be0d

fix name-only attendee search filter support

aa16954

fix display name fallback for name-only attendees

464c711

fix attendee filter to accept name-only values

9d702a8

fix login fallback for name-only attendees

3b68965

add tests for shouldAcceptName option

598df1e

merge origin/main and resolve conflicts

9eda669

lakchote self-assigned this Jan 13, 2026

lakchote added 2 commits January 14, 2026 11:34

fix prettier

acaadd1

fix attendees name

89ddbbb

lakchote force-pushed the lucien/fix-attendees-search branch from 1fd6f9e to 89ddbbb Compare January 14, 2026 12:41

lakchote added 5 commits January 14, 2026 13:58

add eslint-disable for intentional || usage

0f9b16e

fix eslint-disable for multi-line || expression

62c7da5

add tests for getFilteredRecentAttendees

e6ea8e0

add test for attendee filter name preservation

5bedf95

Merge remote-tracking branch 'origin/main' into lucien/fix-attendees-…

1b16099

…search

lakchote added 2 commits January 15, 2026 06:52

Merge main into lucien/fix-attendees-search

f0b43e0

Merge main into lucien/fix-attendees-search

728b738

lakchote changed the title ~~[HOLD Backend PR] Fix filtering attendees names in the Reports page~~ Fix filtering attendees names in the Reports page Jan 16, 2026

lakchote marked this pull request as ready for review January 16, 2026 09:57

lakchote requested review from a team as code owners January 16, 2026 09:57

melvin-bot bot requested review from JmillsExpensify and jjcoffee and removed request for a team January 16, 2026 09:57

lakchote added 3 commits January 19, 2026 20:02

Merge remote-tracking branch 'origin/main' into lucien/fix-attendees-…

175b97a

…search

Merge remote-tracking branch 'origin/main' into lucien/fix-attendees-…

a7285ea

…search

fix typescript check

de6865f

lakchote added 2 commits January 20, 2026 07:10

Merge main into lucien/fix-attendees-search

2bb4acf

fix style

bffe931

Merge branch 'main' into lucien/fix-attendees-search

4e92916

eVoloshchak approved these changes Jan 20, 2026

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar January 20, 2026 13:44

MonilBhavsar approved these changes Jan 21, 2026

View reviewed changes

lakchote merged commit 19ae17a into main Jan 21, 2026
35 checks passed

lakchote deleted the lucien/fix-attendees-search branch January 21, 2026 16:58

OSBotify mentioned this pull request Jan 21, 2026

Deploy Checklist: New Expensify 2026-01-21 #80164

Closed

78 tasks

mitarachim mentioned this pull request Jan 22, 2026

Reports - Name and phone number disappear from Attendees list after reset app/relogin #80175

Closed

7 tasks

lakchote mentioned this pull request Jan 22, 2026

[CP Staging] Revert "Fix filtering attendees names in the Reports page" #80207

Merged

melvin-bot bot mentioned this pull request Jan 22, 2026

Reports - Attendee added with a name, can´t be found when trying to apply "Attendee" filter. #79422

Closed

7 tasks

lakchote mentioned this pull request Jan 28, 2026

Reapply "Fix filtering attendees names in the Reports page" and add improvements #80718

Merged

58 tasks

eVoloshchak mentioned this pull request Mar 25, 2026

[CFI] Fix attendees selection to allow names instead of email or phone only #77993

Open

Conversation

lakchote commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lakchote commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

lakchote commented Jan 19, 2026

Uh oh!

eVoloshchak commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Jan 20, 2026

Uh oh!

eVoloshchak commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

lakchote commented Jan 21, 2026

Uh oh!

MonilBhavsar commented Jan 21, 2026

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

lakchote commented Jan 21, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lakchote commented Jan 13, 2026 •

edited

Loading

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

eVoloshchak commented Jan 19, 2026 •

edited

Loading

eVoloshchak commented Jan 20, 2026 •

edited

Loading