fix: The links are focused and announced twice by nkdengineer · Pull Request #79644 · Expensify/App

nkdengineer · 2026-01-15T08:14:28Z

Explanation of Change

fix: The links are focused and announced twice

Fixed Issues

$ #76922
PROPOSAL: #76922 (comment)

Tests (Web/mWeb only)

Prerequisite:

User is logged in

Tab to focus on the required workspace and press Enter to activate it
Once the Workspace menu is displayed, tab to focus on the "Rules" menu item and press Enter to activate it
Tab to focus on the links "for most USD credit transactions" and "more features"
Verify that the link is focused once

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2026-01-15.at.15.08.58.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2026-01-15.at.15.08.40.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-15.at.15.05.47.mov

melvin-bot · 2026-01-15T08:54:24Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6cd826072

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-15T08:59:56Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

            role={CONST.ROLE.LINK}
+            tabIndex={isSafari() ? 0 : -1}
            accessibilityLabel={href}


Keep non-Safari keyboard focus for onPress-only links

When a link uses onPress without href, the inner Text doesn’t render an anchor, so the only focusable element is the PressableWithSecondaryInteraction. Setting tabIndex={-1} for non‑Safari removes it from the tab order, which means keyboard users on Chrome/Firefox can no longer tab to or activate these links at all. This is a regression for any custom-action links (no href) on non‑Safari browsers, and will also suppress screen reader focus/announcement for those users.

Useful? React with 👍 / 👎.

bernhardoj · 2026-01-15T16:34:43Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

            onPressIn={onPressIn}
            onPressOut={onPressOut}
            role={CONST.ROLE.LINK}
+            tabIndex={isSafari() ? 0 : -1}


Hmm, why do we exclude safari?

@bernhardoj On safari, the link is skipped if we pass tabIndex={-1} here. On safari, it works as expected on main.

@nkdengineer I think we can set tabIndex to -1 on the Text instead?

But before going further, @Expensify/design may I get some opinions here? We have a <a> tag that is wrapped with a Pressable. Both <a> tag and Pressable are "tabbable", so this component is "tabbable" twice. (Our goal is to make it "tabbable" once only)

Except on Safari. On Safari, <a> tag is not "tabbable", but thanks to the Pressable, the link is still "tabbable". My question is, do we want to keep the Safari behavior, so that a link is not "tabbable"?

My question is, do we want to keep the Safari behavior, so that a link is not "tabbable"?

I'm not sure I fully understand what do we mean by "keep the Safari behavior"? If we want it to be pressable once, then we should do what we can to ensure consistency cross platform. So we'd only do safari specific if Safari does something that goes against the cross-platform nature.

@dubielzyk-expensify in Safari, <a> tag is not "tabbable", not navigatable by keyboard. In our app, we wrap the link with a Pressable, so it becomes "tabbable". Do we want to keep that behavior or change it so that it follows the Safari default behavior?

We want the link to be clickable so I believe we want to keep it so that it's navigatable on safari as well 👍 (If I've still understood correctly 😅 )

Okay, got it. Thanks! @nkdengineer can you try this instead?

I think we can set tabIndex to -1 on the Text instead?

OR

Keep setting the tabIndex to -1 on the Pressable and tabIndex 0 on the Text.

@bernhardoj I updated.

@nkdengineer looks like setting tabIndex to -1 on the Text makes it unclickable with the keyboard. Let's use the second approach.

Keep setting the tabIndex to -1 on the Pressable and tabIndex 0 on the Text.

@bernhardoj I updated and it works on safari.

bernhardoj · 2026-01-20T02:44:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

bernhardoj · 2026-01-20T03:05:18Z

@nkdengineer please add a note in test step that it's for web/mweb only

nkdengineer · 2026-01-21T08:34:21Z

@nkdengineer please add a note in test step that it's for web/mweb only

Done.

codecov · 2026-01-21T08:43:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...nchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx	`95.23% <ø> (ø)`
... and 69 files with indirect coverage changes

bernhardoj

LGTM!

OSBotify · 2026-01-21T23:25:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-22T22:53:44Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.3.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-23T22:05:04Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix: The links are focused and announced twice

799ff6a

melvin-bot bot assigned nkdengineer Jan 15, 2026

run prettier

e6cd826

nkdengineer marked this pull request as ready for review January 15, 2026 08:54

nkdengineer requested review from a team as code owners January 15, 2026 08:54

melvin-bot bot requested review from bernhardoj and heyjennahay and removed request for a team January 15, 2026 08:54

melvin-bot bot removed the request for review from a team January 15, 2026 08:54

chatgpt-codex-connector bot reviewed Jan 15, 2026

View reviewed changes

bernhardoj reviewed Jan 15, 2026

View reviewed changes

nkdengineer added 3 commits January 16, 2026 14:00

Merge branch 'main' into fix/76922

5087351

Merge branch 'main' into fix/76922

c2ece74

update tabIndex of text to -1

609fd3c

nkdengineer added 2 commits January 21, 2026 15:30

Merge branch 'main' into fix/76922

f63be45

update tabIndex for text

aeca042

bernhardoj approved these changes Jan 21, 2026

View reviewed changes

melvin-bot bot requested a review from danieldoglas January 21, 2026 15:59

danieldoglas approved these changes Jan 21, 2026

View reviewed changes

danieldoglas merged commit 08aaa7c into Expensify:main Jan 21, 2026
31 checks passed

OSBotify mentioned this pull request Jan 22, 2026

Deploy Checklist: New Expensify 2026-01-22 #80277

Closed

63 tasks

jponikarchuk mentioned this pull request Jan 23, 2026

[$250] Categories & tags links in Rules do not open respective pages when tab & press enter #80349

Closed

7 tasks

melvin-bot bot mentioned this pull request Jan 23, 2026

[Due for payment 2026-01-30] [$125] Keyboard Navigation: Many Pages: The links are focused and announced twice #76922

Closed

Conversation

nkdengineer commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests (Web/mWeb only)

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Jan 20, 2026

Uh oh!

nkdengineer commented Jan 21, 2026

Uh oh!

codecov bot commented Jan 21, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Jan 15, 2026 •

edited

Loading

bernhardoj Jan 19, 2026 •

edited

Loading

bernhardoj commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 21, 2026 •

edited by github-actions bot

Loading