Expense rules phase 2

[situchan]

Explanation of Change

support:

• create new rule
• edit existing rule
• delete selected rule(s)

Fixed Issues

Part of #75903

Tests

For web, go to https://staging.new.expensify.com/settings/rules
For mobile native, open any chat and send message containing this link. Click on link

Error message tests:

1. Click New rule button
2. Click Save rule button
3. Verify that RBR shows above button saying Enter merchant and apply at least one update
4. Add Merchant in If expense contains: section
5. Verify that RBR shows above button saying Please apply at least one update
6. Click back button
7. Click New rule button
8. Add some rules in Then apply these updates: section
9. Click Save rule button
10. Verify that RBR shows above button saying Please enter merchant

(Create report if necessary change doesn't account for Please apply at least one update)

Create new rule flow:

1. Click New rule button
2. Add rules (Merchant is required, others fields are optional)
3. Verify that each rule is added correctly. Note that category, tag, tax rate fields are not visible if doesn't exist (i.e. no workspace created yet after creating new account)
4. Click Save rule
5. Verify that new rule is created successfully

Edit existing rule flow:

1. Select any rule by clicking row in Expense rules table
2. Verify that title shows Edit rule
3. Add or change rules. The logic is same as when create New rule
4. Click Save rule
5. Verify that rule is updated successfully

Delete rule flow:

1. Click checkbox on each row in Expense rules table
2. Verify that x selected dropdown button appears
3. Click dropdown
4. Verify that Edit rule (only when 1 selected), Delete rule(s) menu shows
5. Clicking Edit rule button should be the same flow as edit flow above
6. Click Delete rule(s) button
7. Verify that confirm modal appears
8. Click Delete button
9. Verify that rules are deleted successfully

(Note: for all create/edit/delete, selection is cleared after action is done successfully)

---

Edge cases

• There might be bugs when create multiple rules with the same Merchant name in If expense contains: but not blocker. We're already aware of it.
• There's no offline pattern at the moment. (not sure which pattern to apply for SetNameValuePair apis). As of now, it works same as when online. We can discuss what pattern to follow and fix as follow up but not blocker.

To avoid PR being reverted due to unexpected deploy blockers (hopefully won't happen), I'll hide Expense rules tab in Account setting at the time of merge, like we did in phase 1 read-only mode. We can show it back after QA passes and ready to release production.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79659.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3779ccf-92ab55b1922bb9b4ee1a5c14403d2e20e66ed8e8/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://79659.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[JmillsExpensify]

Ah gotcha, thanks! Will do

[JmillsExpensify]

Going to start posting issues I notice in testing. Looks like we're not handling the encoding of special characters properly.

[JmillsExpensify]

NAB: We probably only need to list a verb once, so "Update expense to billable, category to...." All the Update and Change is unnecessary. I'm fine if we want to address in a follow-up.

[JmillsExpensify]

I wasn't able to successfully get the rule to set the tag. It exists in the personal rule but didn't set on my test expense.

[situchan]

Looks like we're not handling the encoding of special characters properly.

Fixed in latest commit

[situchan]

NAB: We probably only need to list a verb once, so "Update expense to billable, category to...." All the Update and Change is unnecessary. I'm fine if we want to address in a follow-up.

yes, follow-up

[situchan]

I wasn't able to successfully get the rule to set the tag. It exists in the personal rule but didn't set on my test expense.

Does it also happen when configured rule in OD? If so, not blocker. It's separate bug.

[shawnborton]

I think we're missing a search box if the list of rules is quite long:

Unless that was descoped... otherwise it's standard behavior for long tables I think? cc @Expensify/design @JmillsExpensify for the gut check.

[shawnborton]

Small nitpick but at the very bottom of the view, there should be at least 20px of padding. Right now the bottom of the table is quite close to the bottom edge of the view:

[situchan]

@shawnborton Welcome back from OOO!

I think we're missing a search box if the list of rules is quite long

There was no mention of search box, neither scoped nor descoped but agree to have this. I'll fix it as follow-up.

[situchan]

Small nitpick but at the very bottom of the view, there should be at least 20px of padding. Right now the bottom of the table is quite close to the bottom edge of the view:

Screen.Recording.2026-01-22.at.5.04.19.PM.mov

This also happens on other pages like Categories so out of scope. Happy to take and fix this in a separate issue.

[JmillsExpensify]

@shawnborton Welcome back from OOO!

I think we're missing a search box if the list of rules is quite long

There was no mention of search box, neither scoped nor descoped but agree to have this. I'll fix it as follow-up.

Descoped for the v1. Let's do it in follow-up.

[JmillsExpensify]

I wasn't able to successfully get the rule to set the tag. It exists in the personal rule but didn't set on my test expense.

Does it also happen when configured rule in OD? If so, not blocker. It's separate bug.

Good point. Yes, it's an existing bug. We can handle in follow-up.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌