fix: Screen Reader: Many Pages: The embedded links cannot be focused and activated by TaduJR · Pull Request #79826 · Expensify/App

TaduJR · 2026-01-18T08:56:17Z

Explanation of Change

This PR fixes an accessibility issue where embedded links (e.g., "Terms of Service", "Privacy") within muted text blocks couldn't be properly focused and activated by screen readers.

Fixed Issues

$ #77553
PROPOSAL: #77553 (comment)

Tests

Prerequisites: the user is not signed in

Using iOS VoiceOver or Android Talkback, open the Expensify app
Swipe to the 'Phone and email' field
Type the valid email address and double-tap to activate
Swipe and try to focus the 'Terms of Services' and 'Privacy' links
Verify that Each link should be focused separately and announced with a link role and its visible name.

Other Occurrences:

On About: the links Terms of Service and Privacy
On Troubleshoot: 'submit a bug'
Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-App.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Macbook-Chrome.mp4

melvin-bot · 2026-01-18T08:56:24Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/HTMLEngineProvider/HTMLRenderers/MutedTextRenderer.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 089546593c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/HTMLEngineProvider/HTMLRenderers/MutedTextRenderer.tsx

codecov · 2026-01-18T09:06:54Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...vider/HTMLRenderers/AccountManagerLinkRenderer.tsx	`70.00% <ø> (ø)`
...neProvider/HTMLRenderers/ConciergeLinkRenderer.tsx	`0.00% <ø> (ø)`
src/hooks/useEnterKeyHandler.ts	`50.00% <50.00%> (ø)`
...cPressable/implementation/BaseGenericPressable.tsx	`76.10% <30.00%> (-4.67%)`	⬇️
... and 16 files with indirect coverage changes

TaduJR · 2026-01-18T09:31:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b6f49eac0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/HTMLEngineProvider/HTMLRenderers/MutedTextRenderer.tsx

TaduJR · 2026-01-18T11:07:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa710d5cfb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/HTMLEngineProvider/HTMLRenderers/MutedTextRenderer.tsx

…and activated

src/components/HTMLEngineProvider/HTMLRenderers/AccountManagerLinkRenderer.tsx

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

src/components/HTMLEngineProvider/HTMLRenderers/ConciergeLinkRenderer.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 156005d4d2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

trjExpensify

Small accessibility update 👍

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

src/components/HTMLEngineProvider/HTMLRenderers/AccountManagerLinkRenderer.tsx

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

parasharrajat · 2026-01-22T14:30:02Z

@huult will review this...

huult · 2026-01-23T08:12:52Z

@TaduJR Can you reproduce this issue on the latest main branch? I tested on web and iOS native and it’s working fine. Could you check whether it reproduces on Android?

ScreenRecording_01-23-2026.15-11-06_1.MP4

huult · 2026-01-23T08:33:39Z

ScreenRecording_01-23-2026.15-26-18_1.MP4

I can reproduce this issue on the production app.

@rushatgabhane It looks like this issue was fixed by another PR. Do you know which ticket it was related to?

TaduJR · 2026-01-24T20:43:58Z

@TaduJR Can you reproduce this issue on the latest main branch? I tested on web and iOS native and it’s working fine. Could you check whether it reproduces on Android?

Yea no longer repo @huult

But on desktop after navigating by tab clicking enter does not navigate to the link.

huult · 2026-01-25T00:43:20Z

But on desktop after navigating by tab clicking enter does not navigate to the link.

@TaduJR We need to press Control + Option + Space to open it.

Screen.Recording.2026-01-25.at.07.41.14.mov

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

TaduJR · 2026-01-25T05:41:45Z

@huult

@rushatgabhane It looks like this issue was fixed by another PR. Do you know which ticket it was related to?

The VoiceOver navigation issue was fixed by #79147 which added role={CONST.ROLE.LINK}. This allows VoiceOver to announce the element as a "link" and enables Control+Option+Space activation (VoiceOver's universal activate command).

@TaduJR We need to press Control + Option + Space to open it.

The Control+Option+Space is VoiceOver-specific - it only works when VoiceOver is enabled. Per https://www.w3.org/WAI/ARIA/apg/patterns/link/, the Enter key is the standard keyboard activation for links.

rushatgabhane · 2026-01-26T03:03:47Z

yeah feel free to fix it

pressOnEnter should do the job i believe

huult · 2026-01-27T07:05:36Z

@TaduJR please check #79826 (comment) and resolve the conflict.

huult · 2026-01-30T06:15:38Z

Bump @TaduJR

TaduJR · 2026-01-30T13:05:31Z

Bump @TaduJR

Heyy @huult

Sorry I was having deploy blockers.

Will handle it today.

Thanks for the bump!

TaduJR · 2026-01-30T20:53:45Z

yeah feel free to fix it
pressOnEnter should do the job i believe

Thanks @rushatgabhane!

pressOnEnter is for Button components and creates a global keyboard shortcut (fires when Enter is pressed anywhere on the screen).

For links, we need element-specific handling - Enter should only activate the link that currently has focus. Per https://www.w3.org/WAI/ARIA/apg/patterns/link/, "Enter executes the link" means the focused link.

That's why we use onKeyDown on the Text element - it only fires when that specific element is focused and Enter is pressed.

WDYT?

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

Per W3C APG Link Pattern, elements with role=link should be activatable via Enter key. This change adds automatic Enter key handling in GenericPressable when: 1. role=link is set 2. No custom onKeyDown handler is provided 3. onPress exists This fixes keyboard accessibility for MenuItem and other Pressable-based components that use role=link (e.g., AppDownloadLinks page). Also updates useEnterKeyHandler to use CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey instead of hardcoded 'Enter' string.

TaduJR · 2026-01-30T21:26:22Z

@huult

FYI we also discussed at included this fix

https://expensify.slack.com/archives/C01GTK53T8Q/p1769372144160459?thread_ts=1768465127.159179&cid=C01GTK53T8Q

huult · 2026-02-03T02:23:19Z

@TaduJR please resolve the conflict!

huult · 2026-02-03T05:25:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-02-03.at.12.24.02.mov

huult · 2026-02-03T05:28:22Z

#79826 (comment) The original issue was already fixed by another PR.

#79826 (comment) This PR fixed the issue where pressing Enter on a link did not open the URL.

cc @trjExpensify @rushatgabhane

huult · 2026-02-03T05:29:24Z

@TaduJR Please resolve the conflict, and once that’s done, ping me so I can approve this PR.

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

TaduJR · 2026-02-03T16:56:41Z

@TaduJR Please resolve the conflict, and once that’s done, ping me so I can approve this PR.

Done @huult

huult

LGTM

OSBotify · 2026-02-05T20:46:33Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:46:59Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-10T07:02:55Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

TaduJR requested review from a team as code owners January 18, 2026 08:56

melvin-bot bot assigned TaduJR Jan 18, 2026

melvin-bot bot requested review from parasharrajat and trjExpensify and removed request for a team January 18, 2026 08:56

github-actions bot reviewed Jan 18, 2026

View reviewed changes