Skip to content

Fix ExpensiMark formatting display in MODIFIEDEXPENSE messages #82057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 10 commits into from
Mar 18, 2026
Merged

Fix ExpensiMark formatting display in MODIFIEDEXPENSE messages #82057

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6403dd7
Fix MODIFIEDEXPENSE description display to strip HTML formatting
deetergp Feb 10, 2026
e64b2a8
Preserve HTML formatting in MODIFIEDEXPENSE description display
deetergp Feb 10, 2026
48f2c5d
Remove Parser since it's unused
deetergp Feb 10, 2026
882cb5d
Strip HTML from MODIFIEDEXPENSE messages for plain-text consumers
deetergp Feb 10, 2026
fa18af0
Merge branch 'main' into claude-fixExpensiMarkStrikethroughDisplayMod…
deetergp Mar 5, 2026
9e663fd
Add back Parser
deetergp Mar 6, 2026
e1b02aa
Merge remote-tracking branch 'origin/main' into claude-fixExpensiMark…
deetergp Mar 6, 2026
9af5a8f
Merge branch 'main' into claude-fixExpensiMarkStrikethroughDisplayMod…
deetergp Mar 12, 2026
a11dfb5
Use htmlToMarkdown when copying
deetergp Mar 12, 2026
1f30802
Merge branch 'main' into claude-fixExpensiMarkStrikethroughDisplayMod…
deetergp Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libs/ModifiedExpenseMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// eslint-disable-next-line @typescript-eslint/no-deprecated
import {formatList, translateLocal} from './Localize';
import Log from './Log';
import Parser from './Parser';

Check failure on line 17 in src/libs/ModifiedExpenseMessage.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'Parser' is defined but never used

Check failure on line 17 in src/libs/ModifiedExpenseMessage.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'Parser' is defined but never used

Check failure on line 17 in src/libs/ModifiedExpenseMessage.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

'Parser' is defined but never used
Copy link
Copy Markdown
Contributor

@situchan situchan Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still used here:

App/src/libs/ModifiedExpenseMessage.ts

Line 256 in bbb6cbd

return translate('iou.rulesModifiedFields.common', 'description', Parser.htmlToMarkdown(updatedValue), isFirst);

import {getPersonalDetailByEmail} from './PersonalDetailsUtils';
import {getCleanedTagName, getPolicy, getSortedTagKeys, isPolicyAdmin} from './PolicyUtils';
import {getOriginalMessage, isModifiedExpenseAction} from './ReportActionsUtils';
Expand Down Expand Up @@ -277,8 +277,8 @@
buildMessageFragmentForValue(
// eslint-disable-next-line @typescript-eslint/no-deprecated
translateLocal,
Parser.htmlToMarkdown(reportActionOriginalMessage?.newComment ?? ''),
Parser.htmlToMarkdown(reportActionOriginalMessage?.oldComment ?? ''),
reportActionOriginalMessage?.newComment ?? '',
reportActionOriginalMessage?.oldComment ?? '',
Comment thread
deetergp marked this conversation as resolved.
descriptionLabel,
true,
setFragments,
Expand Down Expand Up @@ -574,8 +574,8 @@

buildMessageFragmentForValue(
translate,
Parser.htmlToMarkdown(reportActionOriginalMessage?.newComment ?? ''),
Parser.htmlToMarkdown(reportActionOriginalMessage?.oldComment ?? ''),
reportActionOriginalMessage?.newComment ?? '',
reportActionOriginalMessage?.oldComment ?? '',
descriptionLabel,
true,
setFragments,
Expand Down
Loading