Migration navigation from InteractionManager to TransitionTracker

[blazejkustra]

Explanation of Change

This PR introduces the TransitionTracker and migrates the first batch of InteractionManager usages in navigation code to use it.

TransitionTracker (src/libs/Navigation/TransitionTracker.ts) is a new module that explicitly tracks active transitions (navigation, modal, keyboard, focus) using a counted map. It exposes startTransition/endTransition to mark transition boundaries, and runAfterTransitions to queue callbacks that fire once all transitions are idle. A safety timeout (1s) auto-ends transitions that are never explicitly closed.

On top of TransitionTracker, existing APIs gain transition-aware options:

• Navigation.navigate, goBack, and dismissModal now accept waitForTransition (defer the navigation until ongoing transitions finish) and afterTransition (run a callback after the triggered transition completes). This replaces the old pattern of wrapping navigation calls in InteractionManager.runAfterInteractions.
• dismissModalWithReport uses afterTransition instead of the old DeviceEventEmitter-based MODAL_EVENTS.CLOSED callback pattern. The MODAL_EVENTS.CLOSED constant and its associated DeviceEventEmitter emissions in BaseModal and RightModalNavigator are removed.
• KeyboardUtils.dismiss now accepts { afterTransition, shouldSkipSafari } instead of a bare boolean, and tracks keyboard show/hide as a transition type.
• ScreenLayout (src/libs/Navigation/PlatformStackNavigation/ScreenLayout.tsx) is a new component wired into the web stack navigator via screenLayout prop. It listens to transitionStart/transitionEnd events to feed TransitionTracker.
• ReanimatedModal now calls TransitionTracker.startTransition('modal') / endTransition('modal') alongside the existing InteractionManager handles.

Concrete migration examples in this PR:

• WorkspaceCategoriesSettingsPage and WorkspaceCreateTagPage replace Keyboard.dismiss() + InteractionManager with KeyboardUtils.dismiss({ afterTransition }).
• WorkspaceInviteMessageComponent, NewChatPage, TransactionReceiptModalContent, and Report/index.ts replace dismissModal({ callback }) with dismissModal({ afterTransition }).

Fixed Issues

$ #71913
PROPOSAL:

Tests

1. Replace Reciept:

• Tap on any expense.
• Tap on the receipt.
• Tap 3-dot menu.
• Tap Replace.
• Verify that attachment modal is closed as on production and then RHP is opened

2. Workspace Invite

• Create workspace
• Go to overview page and click Invite button
• On Confirm details page click 'Invite'
• Verify that modal is closed and user is navigated to Members page afterwards

3. Create group

• Click on FAB > Start chat
• choose a user and click 'Add to group'
• On Group details page simply click 'Start group'
• Verify that modal is closed and user is navigated to that report afterwards

4. Navigate to a chat from FAB (RHP)

• Click on FAB > Start chat
• Choose a person (other than self and not the chat that is opened underneath)
• Click on that person
• Verify that modal is closed and user is navigated to that report afterwards

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: Native

Start new chat:

stat-new-chat-ios.mov

Workspace invite:

workspace-invite-ios.mov

Create group:

create-group-ios.mov

Replace receipt:

replace-receipt-ios.mov

Keyboard behaviour:

keyboard-ios.mov

MacOS: Chrome / Safari

Start new chat:
https://github.com/user-attachments/assets/8c36c37f-d457-41ea-8c0c-8b916e129e88

Workspace invite:
https://github.com/user-attachments/assets/ee5d5813-4546-4cef-8464-b4f85261bea6

Create group:
https://github.com/user-attachments/assets/9af3067b-d93b-42c0-97a2-1ab7d03e7cfa

Replace receipt:
https://github.com/user-attachments/assets/99405a86-deb1-4f3b-b229-9fcd23ebfcf4

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	92.56% <ø> (ø)
src/components/Modal/BaseModal.tsx	86.40% <ø> (-0.11%)	⬇️
...on/AppNavigator/Navigators/RightModalNavigator.tsx	5.61% <ø> (+0.06%)	⬆️
...on/createPlatformStackNavigatorComponent/index.tsx	0.00% <ø> (ø)
src/libs/Navigation/TransitionTracker.ts	100.00% <100.00%> (ø)
src/pages/NewChatPage.tsx	73.40% <ø> (ø)
...alScreen/routes/TransactionReceiptModalContent.tsx	0.00% <ø> (ø)
src/utils/keyboard/index.ts	96.00% <100.00%> (+0.76%)	⬆️
src/components/EmojiPicker/EmojiPicker.tsx	45.26% <0.00%> (ø)
src/libs/actions/Report/index.ts	64.88% <0.00%> (ø)
... and 8 more
... and 20 files with indirect coverage changes

[ikevin127]

@blazejkustra That's about it in terms of code review ☝️

🧪 Test Coverage %

The PR introduces no new unit or integration tests - the changed surface area includes:

Module	Test Coverage Added
TransitionTracker.ts	❌ None
ScreenLayout.tsx	❌ None
Navigation.ts (new afterTransition paths)	❌ None
keyboard/index.*.ts	❌ None

Estimated coverage added by author: ~0% of new logic paths. TransitionTracker has clearly testable pure logic (counter semantics, FIFO behavior, callback flushing) and should have unit tests given it's the backbone of the entire migration.

Suggested tests to add:

// TransitionTracker.test.ts
describe('runAfterTransitions', () => {
    it('fires callback immediately when no active transitions', () => {
        const cb = jest.fn();
        TransitionTracker.runAfterTransitions(cb);
        expect(cb).toHaveBeenCalledTimes(1);
    });

    it('defers callback until endTransition is called', () => {
        TransitionTracker.startTransition();
        const cb = jest.fn();
        TransitionTracker.runAfterTransitions(cb);
        expect(cb).not.toHaveBeenCalled();
        TransitionTracker.endTransition();
        expect(cb).toHaveBeenCalledTimes(1);
    });

    it('cancel() prevents deferred callback from firing', () => {
        TransitionTracker.startTransition();
        const cb = jest.fn();
        const handle = TransitionTracker.runAfterTransitions(cb);
        handle.cancel();
        TransitionTracker.endTransition();
        expect(cb).not.toHaveBeenCalled();
    });

    it('fires after safety timeout if endTransition never called', () => {
        jest.useFakeTimers();
        TransitionTracker.startTransition();
        const cb = jest.fn();
        TransitionTracker.runAfterTransitions(cb);
        jest.advanceTimersByTime(1001);
        expect(cb).toHaveBeenCalledTimes(1);
        jest.useRealTimers();
    });
});

---

🔄 Will be moving forward to manual testing...

[collectioneur]

@ikevin127 I’ll investigate the callback issues in dismissModal and navigate and add test to the transitionTracker tomorrow 🙌

[ikevin127]

🟢 Completed PR Reviewer Checklist, manual tests look good.

@ikevin127 I’ll investigate the callback issues in dismissModal and navigate and add test to the transitionTracker tomorrow 🙌

@collectioneur Please let me know when your changes are applied so I can take a final pass at the PR 🙌

🔥 Manual Edge Case / Destructive Regression Tests Report

✅ 1. Double-tap dismiss: Rapidly double-tap "Close" on an RHP. Confirm only one DISMISS_MODAL is dispatched, and afterTransition fires only once. Without debouncing, startTransition could be called twice with only one endTransition, blocking callbacks.
✅ 2. App goes to background mid-transition: Start a navigation, then immediately background the app on iOS. transitionEnd may not fire until the app is foregrounded. Verify the 1s safety timeout resets properly and doesn't leak callbacks across sessions.
✅ 3. Screen with no animation (animation: 'none'): Configure a screen with animation: 'none'. Verify ScreenLayout handles the case where transitionStart/transitionEnd may not fire at all for instant transitions — meaning afterTransition callbacks must fire immediately, not be left pending.
✅ 4. Two simultaneous navigations: Call navigate(routeA) and immediately navigate(routeB). With waitForTransition: false on both, both execute immediately. Verify the second afterTransition doesn't run before the first.
✅ 5. dismissModal while keyboard is visible: Open an RHP with a text input, focus it (keyboard appears), then call dismissModal({afterTransition: ...}). Both keyboard and navigation transitions start. Verify callback fires only after both the keyboard hides and the modal closes — not after just one of them.

📈 PR Strengths

• Clear API improvement: Renaming callback → afterTransition makes intent self-documenting.
• Safety timeout fallback (MAX_TRANSITION_DURATION_MS) prevents indefinitely-blocked callbacks — critical for resilience.
• CancelHandle return value from runAfterTransitions enables clean cleanup for unmounting components.
• Removing DeviceEventEmitter + MODAL_EVENTS.CLOSED eliminates global event pollution and hard-to-trace event listeners.
• Function declaration style for dismissModal and dismissModalWithReport (over const) aligns with the codebase's hoisting and readability conventions.
• INTERACTION_MANAGER.md guide is excellent documentation for future contributors deciding which timing primitive to use.
• waitForTransition option for deferring navigations during active transitions — a genuinely useful addition for complex flows.

[collectioneur]

@ikevin127 I've addressed all the issues and included the necessary tests. It's ready for another review whenever you have a chance 👍

[ikevin127]

🟢 LGTM - Thanks for the changes!

[roryabraham]

looks great. Thanks @blazejkustra and everyone else who contributed to this!

[github-actions]

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82587.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b167caf-fdd2355-d3efa7eeb6c72b25d0fafe531784462ead9b023b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b167caf-fdd2355-2841ce9ef665e5df2762087ce8dba26b336deb4c/index.html

Web 🕸️
https://82587.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[mitarachim]

Deploy Blocker #83727 was identified to be related to this PR.

[jponikarchuk]

Deploy Blocker #83755 was identified to be related to this PR.

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅