[No QA] ci: Add Sentry build size analysis

[rinej]

Explanation of Change

Uploads Android and iOS AdHoc builds to Sentry for size analysis after the Rock Remote Build step
Uses the ARTIFACT_PATH env var set by the Rock actions:
Android:
https://github.com/callstackincubator/android/blob/4cedf4d9b5c167452c96fe67233577e0fde9a025/action.yml#L274
iOS:
https://github.com/callstackincubator/ios/blob/dd30f7e53eee2ea6a59509793d0a30fbb5c91216/action.yml#L372

Fixed Issues

$ #82850
PROPOSAL:

Tests

• Trigger a test build via testBuild.yml from this branch
• Verify the Sentry upload steps appear in the GitHub Actions logs for both Android and iOS jobs
• Confirm builds succeded
• Check Sentry dashboard for AdHoc build size data

Offline tests

QA Steps

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[roryabraham]

@jayeshmangwani no C+ review needed here

[github-actions]

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[roryabraham]

Ok, looks like this worked for iOS but not Android:
https://expensify.sentry.io/explore/releases/?project=4510228107427840&statsPeriod=24h&tab=mobile-builds

Also, can we add a GitHub workflow annotation (with a ::notice:: log) to link to the uploaded Sentry builds?

Also, NAB --log-level debug is more verbose than I imagined

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[rinej]

Great that we have it for ios. Here is also some useful bundle chart, also the potential savings recommendations looks good -> https://expensify.sentry.io/preprod/size/52159/?project=4510228107427840

For the Android issue, the main problem is that it was uploaded with the error:
“Failed to extract basic app information: Could not load binary manifest for APK”

From the CI logs, we can see that the APK was built and uploaded successfully, and the file size is valid (~174MB).

Most likely, the failure occurs when Sentry tried to parse the binary AndroidManifest.xml.

Sentry recommends using sentry-cli >= 2.58.2 for the build upload command. The workflow was using version 2.58.0 (resolved transitively via @sentry/webpack-plugin), which might be the cause of the issue.

I added @sentry/cli as a direct devDependency (pinned to 3.2.0) in package.json
(If we don't want to add it to package.json, we can install it directly in the workflow, let me know what is prefered)

[rinej]

I also added notice logs for better visibility. I know the logs are quite verbose, but once we confirm the flow works as expected, we can remove the --log-level debug flag, before merging to avoid bloating the logs

[github-actions]

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82952.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-99058c0-98deb5d-e750759154b65e05ce9c470cf11be8747e5a521a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-99058c0-98deb5d-cc561bc8054a02da3bd0c18c7df57cfb4998bc1a/index.html

Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

---

👀 View the workflow run that generated this build 👀

[roryabraham]

@rinej can we get an actual table with proper hyperlinks like we see in the existing build summary?

[roryabraham]

Also, it looks like unfortunately the Android build size analysis failed again

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 70 files with indirect coverage changes

[Julesssss]

Oh yes of course, I was using a skill and forgot to mention that in the prompt 😄

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82952.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-101f5a2-47a1081-fd1063e09e90340e4a17ba88c789ccad6797c35f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-101f5a2-47a1081-3e23c97f0c278e608250305fc54f8b8434824e23/index.html

Web 🕸️
https://82952.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[Julesssss]

• Uploaded here
• Build details unavailable still for AdHoc

So I think we go ahead and separately see if Sentry can help us with the Android AdHoc builds

Outdated

[rinej]

Thanks for verifying @Julesssss !

Sentry support suggested adding this verification step to confirm that sentry-debug-meta.properties is present in the APK. This should help rule out the possibility that the issue is on Sentry’s parsing side rather than ours.

The file is embedded by the Sentry Android Gradle plugin and is required for Sentry to correctly process the build. If it’s missing, Sentry won’t be able to associate the uploaded artifact with the project.

I added that step in recent commit, could you run the action again? Thanks!

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82952.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4f7b5b0-65761aa-ba5af93ae3b3ad2622f48a9f9e18e1da7774ec8d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4f7b5b0-65761aa-ce38de769b114facb142319f121d193c50fe1032/index.html

Web 🕸️
https://82952.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[rinej]

I checked the logs, and the sentry-debug-meta.properties file is properly set. This was the potential cause of the issue from Sentry support. I’ve already updated them. I’m not sure how long it will take for them to respond.

@Julesssss , given the urgency of this ticket (I’m not entirely sure how urgent it is), we have the following options:

1. Continue discussion and debugging with the Sentry team - timeline is uncertain, and it’s unclear when we’ll have a resolution.

2. Revert to creating a separate build for uploading the ad-hoc bundle to Sentry – the changes are here were tested here ([No QA] ci: Add Sentry build size analysis #82952 (comment)).
   This will make the flow work, but we’ll need two builds: one for ad-hoc distribution (APK) and one for Sentry upload (AAB).

3. Keep the ad-hoc build as-is, continue discussion with Sentry support, but merge only the release bundle (AAB) – this allows the flow to work, but the ad-hoc build won’t be uploaded to Sentry, we will have only release bundles there.

[Julesssss]

I’ve already updated them

Thanks 👍

This isn't super urgent, but lets merge the release build analysis, which is working. We can keep the issue open in the meantime to work on adhoc builds.

[rinej]

ok, that makes sense👍
I’ve updated the configuration to upload only the release builds. I also updated the post-release comments to include the Sentry URLs, so they’re easier to access and review. Please have a look

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[Julesssss]

Looking good. running test build again in meantime

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82952.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4ba0bae-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4ba0bae-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://82952.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[Julesssss]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[Julesssss]

Moving forward here with the release build analysis

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82952.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7563a9a-9a6f3c4-86af1c66ceede0ed548d7bfb643f15e22626372b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7563a9a-9a6f3c4-c78cf070e8f943fd0679badebcc3f4c0f394436b/index.html

Web 🕸️
https://82952.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[OSBotify]

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅