Fix: Reports RHP briefly opens then closes when accessing expense details#83034
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b4d99d7f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/components/SelectionListWithSections/Search/TransactionGroupListExpanded.tsx
Outdated
Show resolved
Hide resolved
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
|
@ShridharGoel, pr is ready for your review. Please take another look. thanks. |
|
@ShridharGoel, kindly bump. thanks. |
src/components/SelectionListWithSections/Search/TransactionGroupListExpanded.tsx
Outdated
Show resolved
Hide resolved
src/components/SelectionListWithSections/Search/TransactionGroupListExpanded.tsx
Outdated
Show resolved
Hide resolved
|
@ShridharGoel, I've addressed your comments. Please take another look when you get a chance, thanks. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-06.at.8.46.54.PM.movAndroid: mWeb ChromeScreen.Recording.2026-03-06.at.8.54.39.PM.moviOS: HybridAppScreen.Recording.2026-03-06.at.8.51.03.PM.moviOS: mWeb SafariScreen.Recording.2026-03-06.at.8.49.34.PM.movMacOS: Chrome / SafariScreen.Recording.2026-03-06.at.8.45.04.PM.mov |
|
@neil-marcellini, I think this pr is waiting for your review. Could you please take a look? thanks. |
|
@neil-marcellini, kindly bump. thanks. |
|
@ShridharGoel, who is responsible for reviewing this pr? thanks. |
|
@MelvinBot Can you request a review from @neil-marcellini ? |
|
Done! I've requested a review from |
|
Sorry for the delay. I don't tend to see pull requests unless I have a review requested. You can always DM me on Slack in the future too. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks pretty good, but I think there's one thing to fix.
src/components/SelectionListWithSections/Search/TransactionGroupListExpanded.tsx
Outdated
Show resolved
Hide resolved
|
@neil-marcellini, I've addressed your comment. Could you please take another look? thanks. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Great, good to go, thank you.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Explanation of Change
When users opened an expense from grouped search results, the right panel could flash open and then close on first tap (especially after cache clear). These changes make grouped rows use the same reliable open flow as the rest of Search, so the required data is prepared before navigation.
Fixed Issues
$ #80854
PROPOSAL: #80854 (comment)
Tests
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-21.at.4.02.15.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-02-21.at.4.10.59.PM.mov
iOS: Native
Screen.Recording.2026-02-21.at.4.15.04.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-21.at.4.18.57.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-21.at.3.29.22.PM.mov