GPS iOS Live Activity via Airship#83592
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
|
|
🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Dang, iOS failed... |
|
Yeah, once we get iOS up I can take this for a GPS bike ride and see how well it maps the route compared to Garmin... |
|
@shawnborton @JmillsExpensify yes, I need to add new Provisioning Profiles for Live Activity to stop builds from failings, I asked Vit for that and I'm waiting for his response |
|
@dukenv0307 could you do pre-review? Everything is ready I'll just need to update translations and Provisioning Profiles in Xcode to make sure it will build on ad hoc and production. |
|
Sure @GCyganek, I just reviewed the Android PR, will check this one soon |
|
Looking into this, though I need some clarifications for what exactly is required |
src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.ios.ts
Outdated
Show resolved
Hide resolved
|
@GCyganek Can you please update the translation files? |
Asked for translations, will do as soon as they are generated on this PR |
|
Switching to Ready for review to get AI reviews |
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Ok I mirrored the changes made by importing Dev profile to update AdHoc and Release profiles with proper names, let's try the build now. I wasn't sure if it would work without using the binary files of the profiles and importing them using XCode to update |
|
🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
.github/workflows/buildIOS.yml
Outdated
| op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc/OldApp_AdHoc.mobileprovision" --force --out-file ./OldApp_AdHoc.mobileprovision | ||
| op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_Share_Extension/OldApp_AdHoc_Share_Extension.mobileprovision" --force --out-file ./OldApp_AdHoc_Share_Extension.mobileprovision | ||
| op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_Notification_Service/OldApp_AdHoc_Notification_Service.mobileprovision" --force --out-file ./OldApp_AdHoc_Notification_Service.mobileprovision | ||
| op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_LiveActivityExtension/OldApp_AdHoc_LiveActivityExtension.mobileprovision" --force --out-file ./OldApp_AdHoc_LiveActivityExtension.mobileprovision |
There was a problem hiding this comment.
I think you are missing a _ at the end, it's OldApp_Development_Live_Activity_Extension
| op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_LiveActivityExtension/OldApp_AdHoc_LiveActivityExtension.mobileprovision" --force --out-file ./OldApp_AdHoc_LiveActivityExtension.mobileprovision | |
| op read "op://${{ vars.OP_VAULT }}/OldApp_Development_Live_Activity_Extension/OldApp_Development_LiveActivityExtension.mobileprovision" --force --out-file ./OldApp_AdHoc_LiveActivityExtension.mobileprovision |
|
Had to test over here: #84421 (comment) But this is looking really good!
|
|
🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.33-0 🚀
|
|
Deploy Blocker #84518 was identified to be related to this PR. |
|
Deploy Blocker #84554 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀
|

Explanation of Change
Fixed Issues
Adding GPS Live Activity on iOS using Airship.
$ #77226
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13874
Tests
Starting GPS trip and backgrounding the app:
Logging out:
Switch to Expensify Classic:
App termination:
Continue GPS trip recording?modalContinue tripOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-02-26.at.17.05.15.mov
Screen.Recording.2026-02-27.at.12.41.12.mov
Screen.Recording.2026-02-27.at.12.42.25.mov
Screen.Recording.2026-02-27.at.12.43.23.mov