Skip to content

GPS iOS Live Activity via Airship#83592

Merged
AndrewGable merged 20 commits intoExpensify:mainfrom
software-mansion-labs:@GCyganek/gps/ios-gps-live-activity
Mar 6, 2026
Merged

GPS iOS Live Activity via Airship#83592
AndrewGable merged 20 commits intoExpensify:mainfrom
software-mansion-labs:@GCyganek/gps/ios-gps-live-activity

Conversation

@GCyganek
Copy link
Copy Markdown
Contributor

@GCyganek GCyganek commented Feb 26, 2026

Explanation of Change

Fixed Issues

Adding GPS Live Activity on iOS using Airship.

$ #77226
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13874

Tests

Starting GPS trip and backgrounding the app:

  1. Start GPS trip
  2. Navigate to a different screen and background the app
  3. Verify that there is a live activity shown in the dynamic island
  4. Hold the dynamic island to open the expanded widget, verify that it looks and works fine (distance updates)
  5. Tap on the widget
  6. Verify that it opens the app and navigates to the GPS screen with ongoing GPS trip
  7. Background the app again
  8. Tap on the dynamic island
  9. Verify that it opens the app on the GPS screen (there should be no unnecessary navigation animation or anything like that)

Logging out:

  1. Start GPS trip
  2. Background the app and verify that Live Activity has started
  3. Log out
  4. Verify that the GPS Live Activity ended

Switch to Expensify Classic:

  1. Start GPS trip
  2. Background the app and verify that Live Activity has started
  3. Switch to Expensify Classic
  4. Verify that the GPS Live Activity ended

App termination:

  1. Start GPS trip
  2. Background the app and verify that Live Activity has started
  3. Terminate the app
  4. Verify that the GPS Live Activity ended
  5. Open the app again, it should show the Continue GPS trip recording? modal
  6. Tap Continue trip
  7. Background the app and verify that Live Activity is there
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: Native
Screen.Recording.2026-02-26.at.17.05.15.mov
Screen.Recording.2026-02-27.at.12.41.12.mov
Screen.Recording.2026-02-27.at.12.42.25.mov
Screen.Recording.2026-02-27.at.12.43.23.mov

@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Feb 26, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...OURequestStepDistanceGPS/DistanceCounter/index.tsx 0.00% <ø> (ø)
...tep/IOURequestStepDistanceGPS/GPSButtons/index.tsx 0.00% <ø> (ø)
...ou/request/step/IOURequestStepDistanceGPS/const.ts 100.00% <ø> (ø)
src/pages/settings/InitialSettingsPage.tsx 0.00% <ø> (ø)
...tStepDistanceGPS/GPSNotifications/index.android.ts 0.00% <0.00%> (ø)
...st/step/IOURequestStepDistanceGPS/index.native.tsx 0.00% <0.00%> (ø)
...rc/components/GPSTripStateChecker/index.native.tsx 80.00% <0.00%> (-8.89%) ⬇️
...OURequestStepDistanceGPS/GPSNotifications/index.ts 0.00% <0.00%> (-33.34%) ⬇️
src/libs/actions/GPSDraftDetails.ts 0.00% <0.00%> (ø)
...questStepDistanceGPS/GPSNotifications/index.ios.ts 17.14% <17.14%> (ø)
... and 9 files with indirect coverage changes

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@shawnborton
Copy link
Copy Markdown
Contributor

Dang, iOS failed...

@JmillsExpensify
Copy link
Copy Markdown
Contributor

Yeah, once we get iOS up I can take this for a GPS bike ride and see how well it maps the route compared to Garmin...

@GCyganek
Copy link
Copy Markdown
Contributor Author

@shawnborton @JmillsExpensify yes, I need to add new Provisioning Profiles for Live Activity to stop builds from failings, I asked Vit for that and I'm waiting for his response

@GCyganek
Copy link
Copy Markdown
Contributor Author

@dukenv0307 could you do pre-review? Everything is ready I'll just need to update translations and Provisioning Profiles in Xcode to make sure it will build on ad hoc and production.

@dukenv0307
Copy link
Copy Markdown
Contributor

Sure @GCyganek, I just reviewed the Android PR, will check this one soon

@mountiny
Copy link
Copy Markdown
Contributor

Looking into this, though I need some clarifications for what exactly is required

@dukenv0307
Copy link
Copy Markdown
Contributor

@GCyganek Can you please update the translation files?

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented Mar 2, 2026

Can you please update the translation files?

Asked for translations, will do as soon as they are generated on this PR

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented Mar 2, 2026

Switching to Ready for review to get AI reviews

@GCyganek GCyganek marked this pull request as ready for review March 2, 2026 10:35
@GCyganek GCyganek requested review from a team as code owners March 2, 2026 10:35
@melvin-bot melvin-bot bot requested review from dukenv0307 and heyjennahay and removed request for a team March 2, 2026 10:35
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 2, 2026

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented Mar 6, 2026

Ok I mirrored the changes made by importing Dev profile to update AdHoc and Release profiles with proper names, let's try the build now. I wasn't sure if it would work without using the binary files of the profiles and importing them using XCode to update project.pbxproj file

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83592 Mobile-Expensify PR Expensify/Mobile-Expensify#13874.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5b6580a-e53c973e0c-e648523f04e5106217dae3b5cf5c74d08a223e9e/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Web 🕸️
https://83592.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83592 Mobile-Expensify PR Expensify/Mobile-Expensify#13874.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5b6580a-38a96f0489-e648523f04e5106217dae3b5cf5c74d08a223e9e/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Web 🕸️
https://83592.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83592 Mobile-Expensify PR Expensify/Mobile-Expensify#13874.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-70d29ba-38a96f0489-e648523f04e5106217dae3b5cf5c74d08a223e9e/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Web 🕸️
https://83592.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83592 Mobile-Expensify PR Expensify/Mobile-Expensify#13874.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-70d29ba-38a96f0489-e648523f04e5106217dae3b5cf5c74d08a223e9e/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Web 🕸️
https://83592.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc/OldApp_AdHoc.mobileprovision" --force --out-file ./OldApp_AdHoc.mobileprovision
op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_Share_Extension/OldApp_AdHoc_Share_Extension.mobileprovision" --force --out-file ./OldApp_AdHoc_Share_Extension.mobileprovision
op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_Notification_Service/OldApp_AdHoc_Notification_Service.mobileprovision" --force --out-file ./OldApp_AdHoc_Notification_Service.mobileprovision
op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_LiveActivityExtension/OldApp_AdHoc_LiveActivityExtension.mobileprovision" --force --out-file ./OldApp_AdHoc_LiveActivityExtension.mobileprovision
Copy link
Copy Markdown
Contributor

@AndrewGable AndrewGable Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are missing a _ at the end, it's OldApp_Development_Live_Activity_Extension

Suggested change
op read "op://${{ vars.OP_VAULT }}/OldApp_AdHoc_LiveActivityExtension/OldApp_AdHoc_LiveActivityExtension.mobileprovision" --force --out-file ./OldApp_AdHoc_LiveActivityExtension.mobileprovision
op read "op://${{ vars.OP_VAULT }}/OldApp_Development_Live_Activity_Extension/OldApp_Development_LiveActivityExtension.mobileprovision" --force --out-file ./OldApp_AdHoc_LiveActivityExtension.mobileprovision

@AndrewGable
Copy link
Copy Markdown
Contributor

Had to test over here: #84421 (comment)

But this is looking really good!

Screenshot 2026-03-06 at 10 30 29 AM

AndrewGable
AndrewGable previously approved these changes Mar 6, 2026
@AndrewGable AndrewGable merged commit 04835a7 into Expensify:main Mar 6, 2026
39 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@mitarachim
Copy link
Copy Markdown

Deploy Blocker #84518 was identified to be related to this PR.

@mitarachim
Copy link
Copy Markdown

Deploy Blocker #84554 was identified to be related to this PR.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 9, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants