Skip to content

Revert "Migrate useBeforeRemove to usePreventRemove in DiscardChangesConfirmation"#84307

Merged
Julesssss merged 1 commit intomainfrom
revert-78291-mkzie2-issue/76326
Mar 5, 2026
Merged

Revert "Migrate useBeforeRemove to usePreventRemove in DiscardChangesConfirmation"#84307
Julesssss merged 1 commit intomainfrom
revert-78291-mkzie2-issue/76326

Conversation

@Julesssss
Copy link
Copy Markdown
Contributor

@Julesssss Julesssss commented Mar 5, 2026

@Julesssss Julesssss self-assigned this Mar 5, 2026
neil-marcellini
neil-marcellini approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert, approved

@Julesssss Julesssss marked this pull request as ready for review March 5, 2026 19:12
@Julesssss Julesssss requested review from a team as code owners March 5, 2026 19:13
@melvin-bot melvin-bot bot requested a review from joekaufmanexpensify March 5, 2026 19:13
@Julesssss Julesssss merged commit cb8f247 into main Mar 5, 2026
31 of 33 checks passed
@melvin-bot melvin-bot bot removed the request for review from a team March 5, 2026 19:13
@Julesssss Julesssss deleted the revert-78291-mkzie2-issue/76326 branch March 5, 2026 19:13
@melvin-bot melvin-bot bot added the Emergency label Mar 5, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 5, 2026

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team March 5, 2026 19:13
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 5, 2026

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss
Copy link
Copy Markdown
Contributor Author

Julesssss commented Mar 5, 2026

Not emergency, straight revert

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/settings/Profile/Avatar/AvatarPage.tsx 0.00% <0.00%> (ø)
...ges/iou/request/step/IOURequestStepDescription.tsx 0.00% <0.00%> (ø)
.../pages/iou/request/step/IOURequestStepMerchant.tsx 0.00% <0.00%> (ø)
...ou/request/step/IOURequestStepDistanceOdometer.tsx 0.00% <0.00%> (ø)
...t/step/DiscardChangesConfirmation/index.native.tsx 0.00% <0.00%> (ø)
.../request/step/DiscardChangesConfirmation/index.tsx 0.00% <0.00%> (ø)
... and 12 files with indirect coverage changes

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 5, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84307.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cb8f247-3658edd-f4a310d696b7416ba66b2272ab0c2cf35cbe7aad/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cb8f247-3658edd-7e1542b1fc3faf2d38f7ce01e6199dcf460b0d37/index.html
Android iOS
Web 🕸️
https://84307.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

OSBotify pushed a commit that referenced this pull request Mar 5, 2026
@Julesssss @OSBotify
Merge pull request #84307 from Expensify/revert-78291-mkzie2-issue/76326
aedf390 
Revert "Migrate `useBeforeRemove` to `usePreventRemove`  in `DiscardChangesConfirmation`"

(cherry picked from commit cb8f247)

(cherry-picked to staging by blimpich)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 5, 2026
@OSBotify OSBotify mentioned this pull request Mar 5, 2026
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 5, 2026

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

This was referenced Mar 5, 2026
Closed
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 5, 2026

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Julesssss
Copy link
Copy Markdown
Contributor Author

Julesssss commented Mar 5, 2026

Verified resolved, checked off blocker

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@trjExpensify trjExpensify mentioned this pull request Mar 9, 2026
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neil-marcellini neil-marcellini neil-marcellini approved these changes

@joekaufmanexpensify joekaufmanexpensify Awaiting requested review from joekaufmanexpensify

@amyevans amyevans Awaiting requested review from amyevans

Assignees

@Julesssss Julesssss

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Julesssss @OSBotify @neil-marcellini