[Duplicate Expense] Allow bulk duplication. by Krishna2323 · Pull Request #84657 · Expensify/App

Krishna2323 · 2026-03-10T00:22:07Z

Explanation of Change

Fixed Issues

$ #84281
PROPOSAL:

Tests

Same as QA Steps
Verify that no errors appear in the JS console

Offline tests

Follow steps 1–3 from the QA Steps above to set up test data
Turn off network (airplane mode or disconnect Wi-Fi)
Select 2–3 cash expenses and click "Duplicate expense"
Confirm duplicated expenses appear optimistically in the list while offline
Turn the network back on
Confirm the duplicated expenses persist after syncing with the server
Confirm no duplicate or missing entries after reconnection

QA Steps

Log in to the app
Go to expense chat
Create several test expenses:
- At least 2 cash expenses (submitted by you)
- At least 1 Per Diem expense with start & end dates
- At least 1 Per Diem expense without start or end dates (if possible)
- At least 1 Distance expense
- At least 1 card expense (company card)
- At least 1 expense with a receipt currently scanning
- At least 1 expense on a report where you are not the submitter (e.g., as an approver/manager)
Navigate to the Reports page → Expenses tab
Verify option visibility (cash expenses):
- Select a single cash expense (yours) → open the bulk actions menu
- Confirm "Duplicate expense" option appears
- Deselect all
Verify option visibility (multiple cash expenses):
- Select 2 or more cash expenses (yours) → open the bulk actions menu
- Confirm "Duplicate expense" option appears
- Deselect all
Verify card expense exclusion:
- Select only a card expense → open the bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify mixed card + cash exclusion:
- Select a cash expense AND a card expense together → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify scanning expense exclusion:
- Select an expense that is currently scanning → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify mixed scanning + cash exclusion:
- Select a cash expense AND a scanning expense together → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify Per Diem without dates exclusion:
- Select a Per Diem expense that has no start or end dates → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify Per Diem with dates — allowed:
- Select a Per Diem expense that has both start & end dates → open bulk actions menu
- Confirm "Duplicate expense" DOES appear
- Deselect all
Verify non-submitter exclusion:
- Select an expense from a report where you are NOT the submitter (e.g., you are the approver) → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify mixed submitter + non-submitter exclusion:
- Select one of your own expenses AND one from a report where you are not the submitter → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Deselect all
Verify expense report tab exclusion:
- Switch to the Reports tab
- Select one or more reports → open bulk actions menu
- Confirm "Duplicate expense" does NOT appear
- Switch back to Expenses tab
Verify distance expense — allowed:
- Select a distance expense (yours) → open bulk actions menu
- Confirm "Duplicate expense" DOES appear
- Deselect all
Verify mixed allowed types:
- Select a cash expense, a Per Diem (with dates), and a distance expense together → open bulk actions menu
- Confirm "Duplicate expense" DOES appear
- Deselect all
Verify bulk duplication works:
- Select 2–3 cash expenses, note their amounts, merchants, and categories
- Click "Duplicate expense"
- Confirm the selection is cleared after clicking
- Confirm new duplicated expenses appear in the list
- Verify each duplicated expense has the correct amount, merchant, category, and currency
- Verify the date on each duplicate is set to today
- Verify receipt images are NOT copied to the duplicates
Verify duplication works for Draft expenses
Verify duplication works for Processing (submitted) expenses
Verify duplication works for Approved expenses
Verify duplication works for Paid/Reimbursed expenses
Verify single duplicate still works:
- Open a single expense from its report
- Use the three-dot menu → "Duplicate"
- Confirm the expense is duplicated correctly with the same fields
- Verify the single-duplicate animation (icon changes to checkmark, text to "Duplicated", then reverts)
Verify no regression on other bulk actions:
- Confirm bulk Hold, Unhold, Delete, Approve, Pay actions still work as expected when selecting eligible expenses

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2026-03-10T00:22:12Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

codecov · 2026-03-11T01:52:08Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.60% <ø> (ø)`
src/hooks/useBulkDuplicateAction.ts	`100.00% <100.00%> (ø)`
src/components/Search/SearchBulkActionsButton.tsx	`2.85% <0.00%> (-0.09%)`	⬇️
src/components/Search/BulkDuplicateHandler.tsx	`25.00% <25.00%> (ø)`
src/hooks/useSearchBulkActions.ts	`40.24% <86.27%> (+40.24%)`	⬆️
src/libs/actions/IOU/Duplicate.ts	`89.05% <0.00%> (-7.71%)`	⬇️
... and 13 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2026-03-15T12:03:32Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dca96c3007

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/hooks/useSearchBulkActions.ts

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

JmillsExpensify

LGTM for product. Thanks for the extensive testing steps.

situchan · 2026-03-17T14:17:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MelvinBot · 2026-03-17T14:19:23Z

🤖 MelvinBot Code Review

Nice work on this bulk duplicate feature — the eligibility logic is thorough and well-tested. I have one significant concern and a few minor suggestions.

🔴 Performance: 13 new Onyx subscriptions in `useSearchBulkActions`

This hook adds 13 new useOnyx calls (plus useDefaultExpensePolicy), all of which subscribe globally and re-render on every change — even when the user hasn't selected any transactions or has no intention of duplicating:

allReportNameValuePairs, activePolicyID, introSelected, quickAction,
policyRecentlyUsedCurrencies, isSelfTourViewed, transactionDrafts,
betas, personalDetails, recentWaypoints, allPolicyCategories, allPolicyTags

Most of these are only needed at action time (when the user clicks "Duplicate expense"), not at visibility-check time. The visibility check only needs allReportNameValuePairs, allTransactionViolations (already present), and defaultExpensePolicy.

Suggestion: Move the action-time-only Onyx data into the handleDuplicateSelectedTransactions callback (read from Onyx imperatively via Onyx.connect / snapshot) or extract a separate hook that's only mounted when the duplicate option is visible. This would avoid 10+ unnecessary global subscriptions for every user on the search page.

🟡 `shouldShowDuplicateOption` is computed inline in `useMemo` — consider extracting

The visibility logic (lines 1199-1253) is ~55 lines of inline logic inside an already massive useMemo (~400 lines). Other complex checks like merge and split use dedicated helper functions (isMergeActionForSelectedTransactions, shouldShowDeleteOption). Consider extracting a shouldShowBulkDuplicateOption(...) helper for consistency and testability.

🟢 Minor nits

Duplicate getPolicyExpenseChat call — activePolicyExpenseChat is computed both in the visibility check (line 1202) and in handleDuplicateSelectedTransactions (line 734). Since the useMemo already computes it, you could pass it through or compute it once.
allReportNameValuePairs is only used for the distance-expense archived-report check. If this collection is large, consider filtering more selectively (e.g., only fetch NVPs for the selected report IDs).

✅ What looks good

Eligibility checks are comprehensive: managed card, scanning, per-diem dates, submitter validation, custom unit violations, per-diem workspace guard, distance archived/DM checks
Shared optimisticChatReportID/optimisticIOUReportID pattern matches the existing single-duplicate flow in MoneyReportHeader.tsx — this is intentional so all duplicates land on the same report
Test coverage is excellent (840 lines covering visibility, invocation, and edge cases)
Translations provided for all supported locales
Selection is cleared after duplication via clearSelectedTransactions(undefined, true)

situchan · 2026-03-17T14:33:09Z

I think we should address 🔴 and 🟡

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2c989447e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-17T14:45:06Z

src/hooks/useSearchBulkActions.ts

+                    return false;
+                }
+                const reportID = selectedTransactions[id]?.reportID;
+                if (reportID && !isCurrentUserSubmitter(getReportOrDraftReport(reportID))) {


Resolve submitter checks against search snapshot reports

The duplicate-option predicate uses isCurrentUserSubmitter(getReportOrDraftReport(reportID)), which only consults the global report collection. In search flows, selected rows can come from currentSearchResults.data (the hook already handles this for transactions via useAllTransactions()), so a report that is present in the snapshot but not yet hydrated in the collection is treated as missing and therefore “not submitter,” hiding bulk duplicate for otherwise eligible expenses.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-17T14:45:06Z

src/libs/actions/IOU/Duplicate.ts

+            quickAction,
+            policyRecentlyUsedCurrencies,
+            isSelfTourViewed,
+            customUnitPolicyID: targetPolicy?.id,


Pass source policy ID to distance duplication requests

bulkDuplicateExpenses hard-codes customUnitPolicyID to the target/default policy for every transaction, while the duplicated transaction still carries its original customUnitRateID. For distance expenses selected from another workspace, this produces a mismatched rate/policy pair and diverges from the existing report-header duplicate path, which uses the source report policy; the mismatch is forwarded to CREATE_DISTANCE_REQUEST and can cause incorrect duplication behavior for cross-workspace distance expenses.

Useful? React with 👍 / 👎.

…ible. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-17T17:08:24Z

@MelvinBot could you review again? I addressed this comment #84657 (comment)

MelvinBot · 2026-03-17T17:11:14Z

🤖 MelvinBot Follow-up Review

Thanks for the refactor — the performance concern from my previous review is well addressed. Here's my assessment of the changes:

✅ Performance concern resolved

The action-time Onyx subscriptions are now properly isolated:

useBulkDuplicateAction hook — holds the 12+ Onyx subscriptions that are only needed at action time
BulkDuplicateHandler component — only mounts when isDuplicateOptionVisible is true, so subscriptions don't exist for users who aren't duplicating
Policy categories/tags are now fetched by specific policy ID (useOnyx(\...${defaultExpensePolicy?.id}`)`), not the entire collection — much better

✅ Visibility logic extracted

shouldShowBulkDuplicateOption is now a standalone function, which is cleaner and more testable. It also uses searchData to look up reports from search results, which is a nice touch for cases where the search contains reports not in the user's local Onyx store.

✅ Other improvements

isExpenseReportType is hoisted and shared between the visibility check and the options builder (eliminates duplicate computation)
customUnitPolicyID now correctly resolves the source report's policy for distance requests (sourcePolicyID), falling back to targetPolicy?.id
Cleaned up the useMemo dependency array (removed redundant individual icon/style entries)

🟡 One minor nit

In shouldShowBulkDuplicateOption, the searchReports array is rebuilt on every iteration of the .every() loop (lines ~278-283 in the diff). Since it doesn't change between iterations, computing it once before the loop would avoid the repeated Object.keys().filter().map().filter() chain:

const searchReports = searchData
    ? Object.keys(searchData)
          .filter((key) => key.startsWith(ONYXKEYS.COLLECTION.REPORT))
          .map((key) => searchData[key] as Report)
          .filter((report): report is Report => report != null && 'reportID' in report)
    : [];

return selectedTransactionsKeys.every((id) => {
    // ... use searchReports here
});

Not a blocker — just a minor efficiency improvement.

Overall

Looks good! The architecture cleanly separates visibility-time vs. action-time data, the ref-based handler bridge is a reasonable pattern, and the test suite was updated to match the new structure with useSearchBulkActionsWithDuplicate.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-17T17:20:47Z

@situchan all done!

MelvinBot · 2026-03-18T13:00:40Z

I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here).

Failure details: https://github.com/Expensify/Expensify/actions/runs/23245817958

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9036e5ca55

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/Duplicate.ts

src/hooks/useSearchBulkActions.ts

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-18T13:45:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 370c6e3a51

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/Duplicate.ts

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-20T11:51:54Z

@situchan friendly bump

situchan · 2026-03-20T11:53:02Z

reviewing today. please merge main

Krishna2323 added 2 commits March 10, 2026 05:49

[Duplicate Expense] Allow bulk duplication.

5c80f02

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add tests.

0a910f3

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot bot assigned Krishna2323 Mar 10, 2026

Krishna2323 added 4 commits March 10, 2026 06:01

refactor code.

17b8a60

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/84281

cff4f62

minor updates.

e2b5c55

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix optimistic action issue.

2dae542

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 mentioned this pull request Mar 10, 2026

[Duplicate Expense] Allow bulk duplication #84281

Open

Krishna2323 added 5 commits March 11, 2026 02:24

Merge branch 'main' into krishna2323/issue/84281

5760d55

fix tests and ESLint.

9591889

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix tests.

ab91ed8

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add more tests.

c0b25f5

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add missing translations.

2de7466

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 3 commits March 13, 2026 13:18

Merge branch 'main' into krishna2323/issue/84281

55447e2

fix prettier.

0bb2736

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Add submitter and Per Diem date filters to bulk duplicate option

3b6a21e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review March 15, 2026 12:03

Krishna2323 requested review from a team as code owners March 15, 2026 12:03

melvin-bot bot requested review from JmillsExpensify and situchan March 15, 2026 12:03

melvin-bot bot removed request for a team March 15, 2026 12:03

Merge branch 'Expensify:main' into krishna2323/issue/84281

dca96c3

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

src/hooks/useSearchBulkActions.ts Outdated Show resolved Hide resolved

src/hooks/useSearchBulkActions.ts Outdated Show resolved Hide resolved

Krishna2323 added 2 commits March 15, 2026 18:07

address codex review comments.

fe9b4e0

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

update tests.

d2c9894

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

JmillsExpensify previously approved these changes Mar 16, 2026

View reviewed changes

JS00001 previously approved these changes Mar 16, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

perf: defer bulk-duplicate Onyx subscriptions until the option is vis…

c2150c8

…ible. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 dismissed stale reviews from JS00001 and JmillsExpensify via c2150c8 March 17, 2026 17:00

Merge branch 'main' into krishna2323/issue/84281

d2802aa

perf: hoist searchReports computation outside the .every() loop.

d6e1f5d

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/84281

9036e5c

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

src/libs/actions/IOU/Duplicate.ts Outdated Show resolved Hide resolved

src/hooks/useSearchBulkActions.ts Outdated Show resolved Hide resolved

fix: resolve source reports from search data instead of only Onyx.

370c6e3

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

src/libs/actions/IOU/Duplicate.ts Show resolved Hide resolved

fix: carry forward iouReportID across bulk-duplicate loop iterations.

556354f

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

trjExpensify mentioned this pull request Mar 19, 2026

Deleted transactions on search #85818

Open

52 tasks

Merge branch 'Expensify:main' into krishna2323/issue/84281

f59ca89

Conversation

Krishna2323 commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

codecov bot commented Mar 11, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

situchan commented Mar 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 17, 2026

🤖 MelvinBot Code Review

🔴 Performance: 13 new Onyx subscriptions in useSearchBulkActions

🟡 shouldShowDuplicateOption is computed inline in useMemo — consider extracting

🟢 Minor nits

✅ What looks good

Uh oh!

situchan commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Mar 17, 2026

Uh oh!

MelvinBot commented Mar 17, 2026

🤖 MelvinBot Follow-up Review

✅ Performance concern resolved

✅ Visibility logic extracted

✅ Other improvements

🟡 One minor nit

Overall

Uh oh!

Krishna2323 commented Mar 17, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Mar 20, 2026

Uh oh!

Krishna2323 commented Mar 10, 2026 •

edited

Loading

codecov bot commented Mar 11, 2026 •

edited by github-actions bot

Loading

🔴 Performance: 13 new Onyx subscriptions in `useSearchBulkActions`

🟡 `shouldShowDuplicateOption` is computed inline in `useMemo` — consider extracting