Fix/67778 final by dukenv0307 · Pull Request #85024 · Expensify/App

dukenv0307 · 2026-03-12T04:32:36Z

Explanation of Change

Fixed Issues

$ #67778
PROPOSAL:

Tests

Tap the + (FAB) button → Submit expense
On the scan step, take a photo or upload a receipt image
Verify you land on the confirmation step with the receipt attached and no crash/error

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-03-12T04:32:45Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2026-03-12T04:32:47Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12cf324efa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/hooks/useRestartOnReceiptFailure.ts

codecov · 2026-03-12T16:27:38Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`77.86% <100.00%> (-0.03%)`	⬇️
src/libs/actions/IOU/index.ts	`72.62% <100.00%> (-0.30%)`	⬇️
src/libs/actions/Transaction.ts	`68.64% <ø> (-0.39%)`	⬇️
src/libs/actions/TransactionEdit.ts	`80.32% <100.00%> (-2.03%)`	⬇️
src/pages/ReportDetailsPage.tsx	`57.06% <100.00%> (ø)`
src/pages/Share/SubmitDetailsPage.tsx	`0.00% <ø> (ø)`
src/pages/inbox/report/PureReportActionItem.tsx	`56.69% <ø> (ø)`
src/pages/inbox/report/ReportActionItem.tsx	`100.00% <100.00%> (ø)`
...p/IOURequestStepScan/hooks/useMobileReceiptScan.ts	`100.00% <100.00%> (ø)`
...st/step/IOURequestStepScan/hooks/useReceiptScan.ts	`92.10% <100.00%> (+0.21%)`	⬆️
... and 3 more
... and 12 files with indirect coverage changes

dukenv0307 · 2026-03-12T16:45:27Z

For Transaction.ts, the coverage drop (-0.41%) is purely from removing the covered getDraftTransactions function and its Onyx connection — no new uncovered code was introduced (the diff shows <ø>), so there's nothing actionable to test there without writing tests for previously-uncovered code unrelated to this PR.

joekaufmanexpensify · 2026-03-12T21:30:02Z

No product review needed

dukenv0307 · 2026-03-16T08:12:08Z

@DylanDylann can you pls review this PR?

DylanDylann · 2026-03-16T10:06:15Z

@dukenv0307 Could you merge main one more time?

dukenv0307 · 2026-03-17T04:02:15Z

No luck @DylanDylann, can you pls review the PR first?

DylanDylann · 2026-03-18T08:48:20Z

@dukenv0307 I think the failed test is caused by our changes. Could you check again? Also, please merge new main

dukenv0307 · 2026-03-18T09:59:41Z

@DylanDylann I tried to run it locally but it worked well, can you please verify it on your side?

src/libs/actions/IOU/index.ts

src/libs/ReportUtils.ts

src/pages/iou/request/step/IOURequestStepScan/hooks/useMobileReceiptScan.ts

DylanDylann · 2026-03-18T10:20:53Z

src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts

    const selfDMReport = useSelfDMReport();
    const [allTransactionDrafts] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT, {selector: validTransactionDraftsSelector});
    const [amountOwed] = useOnyx(ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED);
+    const draftTransactionIDs = Object.keys(allTransactionDrafts ?? {});


I think we can use validTransactionDraftIDsSelector here

we still need allTransactionDrafts so I think that's fine to extract the keys from allTransactionDrafts

DylanDylann · 2026-03-18T10:23:44Z

The test also failed on my local

…eceiptScan.ts Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>

dukenv0307 · 2026-03-19T05:30:02Z

@DylanDylann can you pls review again? Thanks

DylanDylann · 2026-03-19T07:07:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-19.at.14.59.50.mov

DylanDylann

LGTM

MarioExpensify

Awesome, thank you!!

OSBotify · 2026-03-19T12:34:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-19T12:34:38Z

🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T12:39:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85024.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7933470-5a38169-ef2b4a4be314ad2c289f81e0206cbd3563730a20/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7933470-5a38169-20de3dd9585883ec30e922929d97b0436265a84e/index.html

Web 🕸️
https://85024.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T20:24:55Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:27:12Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 added 2 commits March 12, 2026 11:30

clean up allTransactionDrafts

596f0c0

decrease max warnings

12cf324

dukenv0307 marked this pull request as ready for review March 12, 2026 04:32

melvin-bot bot assigned dukenv0307 Mar 12, 2026

dukenv0307 requested review from a team as code owners March 12, 2026 04:32

melvin-bot bot requested a review from DylanDylann March 12, 2026 04:32

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 12, 2026 04:32

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

src/hooks/useRestartOnReceiptFailure.ts Show resolved Hide resolved

dukenv0307 added 2 commits March 12, 2026 23:03

Merge branch 'main' into fix/67778-final

a9e823b

update tet

fca5bef

add tests

1b388a7

joekaufmanexpensify removed their request for review March 12, 2026 21:30

dukenv0307 added 3 commits March 16, 2026 11:53

merge main

bc36788

remove unncessary changes

7b9e389

lint fix

cbe50eb

dukenv0307 added 2 commits March 16, 2026 23:42

Merge branch 'main' into fix/67778-final

1b75420

merge main

68beb6c

DylanDylann reviewed Mar 18, 2026

View reviewed changes

dukenv0307 and others added 4 commits March 19, 2026 10:48

update comments

d430c6c

update test

1015e7e

merge main

9aa32e9

Update src/pages/iou/request/step/IOURequestStepScan/hooks/useMobileR…

f0b2350

…eceiptScan.ts Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>

DylanDylann approved these changes Mar 19, 2026

View reviewed changes

melvin-bot bot requested a review from MarioExpensify March 19, 2026 08:01

MarioExpensify reviewed Mar 19, 2026

View reviewed changes

MarioExpensify approved these changes Mar 19, 2026

View reviewed changes

MarioExpensify merged commit 7933470 into Expensify:main Mar 19, 2026
33 of 34 checks passed

dukenv0307 mentioned this pull request Mar 19, 2026

[Due for payment 2026-03-30] [Due for payment 2026-03-19] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT in src/libs/actions/Transaction.ts #67778

Closed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

Conversation

dukenv0307 commented Mar 12, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Mar 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Mar 12, 2026

Uh oh!

joekaufmanexpensify commented Mar 12, 2026

Uh oh!

dukenv0307 commented Mar 16, 2026

Uh oh!

DylanDylann commented Mar 16, 2026

Uh oh!

dukenv0307 commented Mar 17, 2026

Uh oh!

DylanDylann commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Mar 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Mar 18, 2026

Uh oh!

dukenv0307 commented Mar 19, 2026

Uh oh!

DylanDylann commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

codecov bot commented Mar 12, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Mar 18, 2026 •

edited

Loading

DylanDylann commented Mar 19, 2026 •

edited

Loading