refactor getParentNavigationSubtitle to use policy from useOnyx#85211
refactor getParentNavigationSubtitle to use policy from useOnyx#85211lakchote merged 8 commits intoExpensify:mainfrom
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 674665e793
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/libs/ReportUtils.ts
Outdated
|
|
||
| if (isInvoiceReport(report) || isInvoiceRoom(parentReport)) { | ||
| let reportName = `${getPolicyName({report: parentReport})} & ${getInvoicePayerName(parentReport)}`; | ||
| let reportName = `${getPolicyName({report: parentReport, policy})} & ${getInvoicePayerName(parentReport)}`; |
There was a problem hiding this comment.
Avoid reusing child policy for parent report subtitle
getParentNavigationSubtitle now forwards the caller-provided policy while resolving names for parentReport, but getPolicyName prioritizes that explicit policy over the parent report’s own policyID. In flows that pass usePolicy(report.policyID) from the child report (e.g., header/details), this will show an incorrect workspace in the parent navigation subtitle whenever parent and child policies differ (or parent has no policy).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
report policy will be the same as parent report policy
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dukenv0307 Is this ready? |
|
@DylanDylann yes |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-03-25.at.16.20.25.mov |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.44-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.47-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.3.48-2 🚀
|
Explanation of Change
Fixed Issues
$ #66415
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari