fix: 85431 Improve animations for flows using useSubPage by MrMuzyk · Pull Request #85531 · Expensify/App

MrMuzyk · 2026-03-17T12:55:19Z

Explanation of Change

reverted animation changes for screens using useSubPage
simplified redirect to correct sub page upon opening flow using useSubPage
updated tests

Fixed Issues

$ #85431
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log into an account with private personal details already set
Open the missing personal details flow: https://new.expensify.com/missing-personal-details/123456789
On the confirmation page, use the in-app back button to navigate back through the steps
Each step previous step slides in from the left showing that we're navigating backwards

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

…1-improve-animations-for-use-sub-page

melvin-bot · 2026-03-18T13:08:19Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c0b915b8c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-18T13:23:17Z

src/hooks/useSubPage/index.tsx

-            cancelAnimationFrame(requestID);
-        };
-    }, [isRedirecting, startPageName, buildRoute]);
+        navigation.setParams({subPage: startPageName} as Record<string, unknown>);


Wait for startFrom to settle before setting the initial subPage

When a useSubPage screen opens without :subPage, this now calls setParams() on the first effect tick and permanently makes urlPageName truthy. In MissingPersonalDetailsContent, startFrom depends on shouldCollectPIN, which is still derived from ONYXKEYS.CARD_LIST after mount (src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx:66-90), and getInitialSubPage() only routes to PIN once that flag is true (src/pages/MissingPersonalDetails/utils.ts:26-48). If the card list arrives after the first render, the hook has already locked the route to the earlier page and will never redirect again, so UK/EU card users can reopen the flow on confirm instead of the required PIN step.

Useful? React with 👍 / 👎.

I think it's very unlikely as ONYXKEYS.CARD_LIST is fetched before we show this screen. @dukenv0307 wdyt?

Replied on Slack

We've discussed in slack and in result Ive added a simple check that should prevent this

JmillsExpensify

LGTM

codecov · 2026-03-19T10:19:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSubPage/index.tsx	`100.00% <100.00%> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.30% <ø> (-0.02%)`	⬇️
...gPersonalDetails/MissingPersonalDetailsContent.tsx	`0.00% <0.00%> (ø)`
... and 171 files with indirect coverage changes

dukenv0307 · 2026-03-19T11:37:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-19.at.18.35.31.mov

Android: mWeb Chrome

Screen.Recording.2026-03-19.at.18.23.08.mov

iOS: HybridApp

Screen.Recording.2026-03-19.at.18.39.49.mov

iOS: mWeb Safari

Screen.Recording.2026-03-19.at.18.20.23.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-19.at.18.14.55.mov

dukenv0307 · 2026-03-19T11:39:21Z

@MrMuzyk @arosiclair I found 1 issue that's not related to our PR, we still can reproduce in staging

Go to https://staging.new.expensify.com/missing-personal-details/123456789
Enter the invalid value
Edit the URL to https://staging.new.expensify.com/missing-personal-details/123456789, then enter

Current behavior:
The current step is skipped

Expected behavior:
The current step is shown

Screen.Recording.2026-03-19.at.18.37.47.mov

dukenv0307

LGTM

arosiclair · 2026-03-19T15:43:57Z

@MrMuzyk @arosiclair I found 1 issue that's not related to our PR, we still can reproduce in staging

Go to https://staging.new.expensify.com/missing-personal-details/123456789

Enter the invalid value

Edit the URL to https://staging.new.expensify.com/missing-personal-details/123456789, then enter

Current behavior: The current step is skipped

Expected behavior: The current step is shown

I think this is okay for now since the value can be fixed on the confirmation screen and the API should reject anything invalid.

github-actions · 2026-03-19T15:46:31Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T15:53:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85531.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7267ff1-c628576-961e83ec63718b95d7cbda7d0da7981acf939e0d/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://85531.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T15:55:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-19T20:26:04Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:29:27Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: 85431 Improve animations for flows using useSubPage

d9b23b2

melvin-bot bot assigned MrMuzyk Mar 17, 2026

MrMuzyk added 3 commits March 18, 2026 10:07

Merge branch 'main' of https://github.com/Expensify/App into fix/8543…

b31a669

…1-improve-animations-for-use-sub-page

tests

50cba23

fix: revert animation change

2c0b915

MrMuzyk marked this pull request as ready for review March 18, 2026 13:08

MrMuzyk requested review from a team as code owners March 18, 2026 13:08

melvin-bot bot requested review from dukenv0307 and removed request for a team March 18, 2026 13:08

melvin-bot bot requested review from JmillsExpensify and removed request for a team March 18, 2026 13:08

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

JmillsExpensify reviewed Mar 18, 2026

View reviewed changes

dukenv0307 mentioned this pull request Mar 19, 2026

[CBN] Non-USD flow refactor #83308

Open

53 tasks

fix: safety check when data is not loaded

454a92a

dukenv0307 approved these changes Mar 19, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair March 19, 2026 11:41

arosiclair approved these changes Mar 19, 2026

View reviewed changes

arosiclair merged commit 7267ff1 into Expensify:main Mar 19, 2026
32 of 33 checks passed

github-actions bot mentioned this pull request Mar 19, 2026

Investigate workflow job failing on main: build (developmentDebug, false) #85823

Closed

github-actions bot mentioned this pull request Mar 19, 2026

Investigate workflow job failing on main: build (New Expensify Dev, DebugDevelopment, false) #85826

Closed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

melvin-bot bot mentioned this pull request Mar 23, 2026

[Due for payment 2026-03-30] Navigating backwards in RHP flow uses the wrong animation #85431

Closed

7 tasks

Conversation

MrMuzyk commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

MrMuzyk Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

MrMuzyk Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

arosiclair commented Mar 19, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MrMuzyk commented Mar 17, 2026 •

edited

Loading

codecov bot commented Mar 19, 2026 •

edited by github-actions bot

Loading

dukenv0307 commented Mar 19, 2026 •

edited

Loading

dukenv0307 commented Mar 19, 2026 •

edited

Loading