fix: android pressability issue with measureAsyncOnUI patch by MelvinBot · Pull Request #85543 · Expensify/App

MelvinBot · 2026-03-17T14:10:25Z

Explanation of Change

This PR adds a react-native patch based on the upstream PR facebook/react-native#51835 to fix an Android-specific issue where onPress events do not trigger for Pressable components when used inside a Tooltip on certain Samsung devices.

Root Cause: In the new architecture, Pressability.measure() reads layout information from the shadow tree. When a tooltip uses a Reanimated animation (e.g., scale: 0 during entry), the shadow tree retains the stale value while the UI thread has already updated. This causes Pressability to incorrectly compute the pressable region as having zero size, making the button untappable.

Fix: Introduces a new measureAsyncOnUI method that measures views using the native view hierarchy on the UI thread instead of the shadow tree. This ensures correct measurements even when Reanimated has modified the view's transform on the native side.

The patch modifies:

JS: Pressability.js to call measureAsyncOnUI instead of measure; adds measureAsyncOnUI to FabricUIManager, ReactFabricHostComponent, ReactNativeElement, and type definitions
C++ (shared): Adds measureAsyncOnUI binding in UIManagerBinding.cpp, with delegation through UIManagerDelegate → Scheduler → SchedulerDelegate
iOS: Implements async measurement in RCTMountingManager using RCTExecuteOnMainQueue with native view hierarchy measurement
Android: Implements async measurement through FabricUIManager → MountingManager using MountItem dispatch to UI thread, with native view hierarchy measurement via bounding box computation

Also removes the createPressHandler workaround (which used onPressIn instead of onPress on Android) since this patch properly fixes the root cause.

Fixed Issues

$ #59953

Tests

Open the app on an Android device (ideally a Samsung Galaxy Z Fold 4 or similar affected device)
Sign in to a new account or one that triggers product training tooltips
When a tooltip appears (e.g., near the Concierge chat), tap the X button to dismiss it
Verify the tooltip dismisses on tap (onPress fires correctly)
If action button tooltips appear, verify "Try it out" and "No thanks" buttons work

Verify that no errors appear in the JS console

Offline tests

Same as tests - tooltip dismissal is a local UI interaction and should work identically offline.

QA Steps

On an Android device (preferably Samsung Galaxy Z Fold 4 / Android 14), sign in to an account
Trigger a product training tooltip (new account or cleared tooltip state)
Verify the X button on the tooltip is tappable and dismisses the tooltip
Verify other Pressable components inside tooltips work correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

This bug requires a specific Samsung device (e.g., Galaxy Z Fold 4) to reproduce. The patch is based on the upstream react-native fix.

Android: mWeb Chrome

N/A - This is a native-only issue (Fabric/new arch)

iOS: Native

N/A - This is an Android-specific issue

iOS: mWeb Safari

N/A - This is an Android-specific issue

MacOS: Chrome / Safari

N/A - This is an Android-specific issue

Adds a patch-package patch for react-native 0.81.4 based on upstream PR facebook/react-native#51835. This introduces a new measureAsyncOnUI method that measures views using the native layout hierarchy on the UI thread, fixing an issue where Pressable components inside Tooltips fail to trigger onPress on certain Samsung Android devices. Also removes the createPressHandler workaround that was using onPressIn as a temporary fix for the same issue. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

MelvinBot · 2026-03-17T14:41:21Z

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/23198481953

MelvinBot · 2026-03-17T15:11:48Z

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/23198835377

linhvovan29546 · 2026-03-19T07:54:35Z

@codex review

linhvovan29546 · 2026-03-19T07:55:28Z

@MelvinBot Please check the workflows, they're failing

The patch file had bare newlines inside diff hunks where unified diff format requires a space-prefixed line for context. This caused patch-package to fail with "could not be parsed" during npm install, breaking all CI checks. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8318e7979

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T08:16:38Z

patches/react-native/react-native+0.81.4+030+fix-pressability-new-arch.patch

+    if (!view) {
+      // this view was probably collapsed out
+      RCTLogWarn(@"measure cannot find view with tag #%@", reactTag);
+      callbackCopy({});
+      return;


Return a full measurement payload when iOS lookup fails

If the pressed Fabric view is collapsed or unmounted before RCTExecuteOnMainQueue runs, this branch calls callbackCopy({}). The new UIManagerBinding::measureAsyncOnUI bridge added later in this patch unconditionally reads args.at(0) through args.at(5), so an empty payload turns a benign "view disappeared" case into an out-of-bounds native exception. On iOS, a quick press on a disappearing view can therefore crash instead of simply skipping the measurement.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-19T08:16:38Z

patches/react-native/react-native+0.81.4+030+fix-pressability-new-arch.patch

+    val rootView = try {
+      smm.getView(surfaceId)
+    } catch (ex: IllegalViewOperationException) {


Measure Android dialog content against its real native root

measureAsyncOnUI() subtracts the coordinates of smm.getView(surfaceId), but Android Modal content is rendered under ReactModalHostView's DialogRootViewGroup, not under the surface root. In that case the computed pageX/pageY are relative to the activity root instead of the dialog window, so Pressability still compares touches against the wrong region and buttons inside modal/dialog content can miss presses or cancel unexpectedly. The old NativeViewHierarchyManager.measure() logic walked from the pressed view to its actual native root, which avoided this offset.

Useful? React with 👍 / 👎.

MelvinBot · 2026-03-19T08:16:52Z

All CI checks were failing due to a patch file parse error during npm install.

Root Cause: The patch file react-native+0.81.4+030+fix-pressability-new-arch.patch had 27 bare newlines (\n) inside diff hunks where unified diff format requires space-prefixed lines ( \n) for blank context lines. This caused patch-package to fail with "could not be parsed", which broke npm install and cascaded to every CI job.

Fix: Added the missing space prefix to all 27 blank context lines in the patch file (commit a477f37). CI should pass on the next run.

linhvovan29546 · 2026-03-19T08:20:53Z

@MelvinBot Please merge main branch and apply the fix

MelvinBot · 2026-03-19T08:28:01Z

The branch claude-fixPressabilityNewArch had no shared git history with main (it was created as an orphan commit), making git merge main impossible without --allow-unrelated-histories which creates conflicts on every file.

I've recreated the PR with a proper branch based on main, including all the same changes plus the patch file parse fix: #85745

Please close this PR and use the new one instead.

MelvinBot · 2026-03-19T08:47:19Z

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/23285899275

The react-native patch file had 8 incorrect @@ hunk headers where the declared old/new line counts didn't match the actual hunk body content. This caused patch-package's verifyHunkIntegrity check to fail with "the patch file could not be parsed", breaking all CI checks. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

MelvinBot · 2026-03-19T09:10:23Z

Fixed the failing checks: The react-native+0.81.4+030+fix-pressability-new-arch.patch file had 8 incorrect @@ hunk headers where the declared old/new line counts didn't match the actual hunk body content. This caused patch-package's verifyHunkIntegrity check to fail with "the patch file could not be parsed" during npm install, which broke all CI checks.

Corrected hunk headers:

RCTMountingManager.mm: -8,6 +8,7 → -8,5 +8,6
MountingManager.kt: -343,6 +348,55 → -343,5 +348,66
NativeDOM.cpp: -13,6 +13,7 → -13,4 +13,5
UIManagerBinding.cpp: -663,6 +663,46 → -663,6 +663,47
UIManagerDelegate.h: -90,6 +90,14 → -90,5 +90,13
mockNativeComponent.js: -38,6 +38,7 → -38,4 +38,5
HostInstance.js: -71,6 +71,11 → -71,4 +71,9
ReactNativeElement.js: -155,6 +155,16 → -155,6 +155,17

The patch file was missing the required `index` header lines that patch-package uses to parse diff sections, causing all CI checks to fail during npm install. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

MelvinBot · 2026-03-19T09:26:49Z

Fixed the failing checks: the patch file react-native+0.81.4+030+fix-pressability-new-arch.patch was missing required index header lines between each diff --git and --- line. patch-package's parser needs these lines to correctly parse diff sections. Added the missing index 0000000..0000000 100644 lines to all 24 diff sections in the patch.

linhvovan29546 · 2026-03-19T09:27:51Z

@MelvinBot Please close this PR

MelvinBot · 2026-03-19T09:29:49Z

Closed this PR as requested by linhvovan29546.

MelvinBot · 2026-03-19T09:52:00Z

Fixed the failing checks: the react-native+0.81.4+030+fix-pressability-new-arch.patch file had an incorrect hunk header for the Scheduler.h section. The header declared 6 original lines (@@ -106,6 +106,9 @@) but the hunk body only contained 5 context lines. This caused patch-package to fail with "could not be parsed", which broke all downstream checks (ESLint, Prettier, etc.) during npm install.

Fixed by correcting the header to @@ -106,5 +106,9 @@.

MelvinBot · 2026-03-19T10:22:38Z

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/23288407374

MelvinBot assigned linhvovan29546 Mar 17, 2026

MelvinBot requested a review from a team March 17, 2026 14:10

MelvinBot mentioned this pull request Mar 17, 2026

[$375] Android: Investigate and fix onPress not working for Pressable in Tooltip #59953

Open

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Fix: add missing index lines to react-native patch file

bcea496

The patch file was missing the required `index` header lines that patch-package uses to parse diff sections, causing all CI checks to fail during npm install. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

MelvinBot closed this Mar 19, 2026

Conversation

MelvinBot commented Mar 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

linhvovan29546 commented Mar 19, 2026

Uh oh!

linhvovan29546 commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

linhvovan29546 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

linhvovan29546 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants