Part 8 - Thread betas through navigateToAndOpenReportWithAccountIDs#85707
Part 8 - Thread betas through navigateToAndOpenReportWithAccountIDs#85707rlinoz merged 6 commits intoExpensify:mainfrom
Conversation
…t yet. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-03-19.at.17.44.52.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #66417 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
|
||
| // We are already on the parent one expense report, so just call the API to fetch report data | ||
| openReport({reportID: parentReportID, introSelected: undefined}); | ||
| openReport({reportID: parentReportID, introSelected: undefined, betas: undefined}); |
There was a problem hiding this comment.
Why we don't need the betas here? And if we really don't, wouldn't it be better if that was the default value so we don't have to be explicit about it?
There was a problem hiding this comment.
betas is safe to pass as undefined here because introSelected is always undefined in these calls, so the code path that uses betas is never reached. We're passing it explicitly (rather than omitting it) so that the compiler will flag these call sites when we make betas required in a future PR. I've added a comment to clarify this.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66417
PROPOSAL:
Tests
Same as QA steps
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-03-19.02-12-35.mp4